[SRU] python-rpy doesn't follow debian python policy

Bug #70495 reported by Luis de Bethencourt Guimerá
6
Affects Status Importance Assigned to Milestone
rpy (Debian)
Fix Released
Unknown
rpy (Ubuntu)
Fix Released
Undecided
Unassigned
Edgy
Fix Released
Undecided
LaserJock

Bug Description

Binary package hint: python-rpy

python-rpy doesn't follow debian python policy. Which results in installing the .py in the wrong folder, and then python doesn't recognize the library and when importing in python it looks like it doesn't exist.

Related branches

Revision history for this message
Luis de Bethencourt Guimerá (luisbg) wrote :

sudo cp /usr/share/pycentral/python-rpy/site-packages/rpy* /usr/lib/python2.4/site-packages/

that is a ugly fix... but proves that the bug is that the actual python-rpy package installes the files in the wrong destination. will try to correct the destionation in the package tomorrow.

Revision history for this message
Kai Kasurinen (kai-kasurinen) wrote :

Fixed in Debian:

rpy (0.99.2-5) unstable; urgency=low
 .
   * debian/rules: Call dh_installdeb after dh_pycentral (Closes: #378755)

Changed in rpy:
status: Unconfirmed → Confirmed
Changed in rpy:
status: Unknown → Fix Released
Revision history for this message
LaserJock (laserjock) wrote :

working on Edgy SRU

Changed in rpy:
assignee: nobody → mantha
Revision history for this message
LaserJock (laserjock) wrote :

Fixed in Feisty

Changed in rpy:
status: Unconfirmed → Confirmed
status: Confirmed → Fix Released
Revision history for this message
LaserJock (laserjock) wrote :

The edgy version (0.99.2-4build1) of rpy has broken maintainer scripts because dh_installdeb is called before dh_pycentral. The result is that the python files are not installed to directory in the python path. If you run:
python
importy rpy
it can't find the rpy modules. This was fixed in Debian with version (0.99.2-5) by putting dh_installdeb later in debian/rules and adding python-rpy.{preinst,postinst,prerm} and I am attaching a debdiff that backports this fix. The impact is that python-rpy is totally unusable on edgy as is.

Revision history for this message
StefanPotyra (sistpoty) wrote :

Hi,

looks quite good, just one small point: IIRC the postinst/prerm that are noops and only placeholders for #DEBHELPER# get created automatically, can you please check this and if so remove them from the patch?

Thanks,
    Stefan.

Revision history for this message
LaserJock (laserjock) wrote :

Ok, new debdiff. I just grabbed the maintainer scripts as they were part of the "fix" the Debian maintainer did. It works fine without them as Stefan said so I just moved dh_installdeb and that's it.

Revision history for this message
StefanPotyra (sistpoty) wrote :

Eeks, sorry I once again haven't been clear enough:

The preinst shouldn't imo go away, since these remove stale pyo/pyc files (from the previous location). In theory this would only affect dapper->edgy upgraders (since /usr/lib/python2.4/site-packages/rpy/ only existed in the dapper version, no longer in the edgy one, but better safe than sorry I'd say.)

Cheers,
    Stefan.

Revision history for this message
LaserJock (laserjock) wrote :

OK Stefan, here you go :-)
The reason I took out the .prerm in the last one was that I don't know of any other python packages doing that. It makes sense though. This latest debdiff should do the trick.

Revision history for this message
StefanPotyra (sistpoty) wrote :

+1

Revision history for this message
Daniel T Chen (crimsun) wrote :

Looks sane, +1.

Revision history for this message
Steve Kowalik (stevenk) wrote :

Also looks sane to me, +1.

Revision history for this message
StefanPotyra (sistpoty) wrote :

is this uploaded to -proposed already?

Revision history for this message
StefanPotyra (sistpoty) wrote :

note to self: This package has already been uploaded to -proposed.

Revision history for this message
Tollef Fog Heen (tfheen) wrote :

Accepted into edgy-proposed, please solicit testing.

Changed in rpy:
status: Confirmed → Fix Committed
Revision history for this message
StefanPotyra (sistpoty) wrote :

Works for me.

Revision history for this message
LaserJock (laserjock) wrote :

Accepted:
 OK: rpy_0.99.2-4ubuntu1.dsc
     -> Component: universe Section: python
 OK: rpy_0.99.2-4ubuntu1.diff.gz
This upload awaits approval by a distro manager

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 6 Mar 2007 16:08:31 -0800
Source: rpy
Binary: python-rpy python-rpy-doc
Architecture: source
Version: 0.99.2-4ubuntu1
Distribution: edgy-updates
Urgency: low
Maintainer: Dirk Eddelbuettel <email address hidden>
Changed-By: Jordan Mantha <email address hidden>
Description:
 python-rpy - Python interface to the GNU R language and environment
 python-rpy-doc - Python interface to the GNU R language (documentation package)
Changes:
 rpy (0.99.2-4ubuntu1) edgy-updates; urgency=low
 .
   * No-change upload propagating SRU to -updates (LP: #70495)
     - Tested by Jordan Mantha and Stefan Potyra
 .
 rpy (0.99.2-4ubuntu1~prop1) edgy-proposed; urgency=low
 .
   * SRU: backport of python-central fix from 0.99.2-5 (Closes: Malone #70495)
     - Add python-rpy.preinst to remove old .pyc files
     - Call dh_installdeb after dh_pycentral in debian/rules
Files:
 682b93a31ca078ec214a7a0c3f07d195 739 python optional rpy_0.99.2-4ubuntu1.dsc
 6d37aa81c00424140188bc2f3658ce35 31671 python optional rpy_0.99.2-4ubuntu1.diff.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFF8K/A3mtKw5J0KzMRAh8DAKCbZI7XJKPzeoS7+LJ0E72eUrYU/wCdH3hm
NCwHahz85BF0fnPYf7VQ6Ng=
=ICxE
-----END PGP SIGNATURE-----

Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into edgy-updates.

Changed in rpy:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.