Confirmation for "bin/glance clear" and "bin/glance delete <id>"
Bug #768979 reported by
Édouard Thuleau
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Glance |
Fix Released
|
Medium
|
Brian Waldon | ||
Bug Description
Glance bzr123
When I use 'glance delete <id>' or 'glance clear' a user confirmation is needed :
Delete all images? [Y/n] or Delete image 2? [Y/n]
Normally, if we put 'Y' in uppercase, it will be the default value if the user doesn't precise nothing.
$glance delete 2
Delete image 2? [Y/n]
Not deleting image 2
$ glance delete 2
Delete image 2? [Y/n] y
Deleted image 2
$ glance clear
Delete all images? [Y/n]
Not deleting any images
$ glance clear
Delete all images? [Y/n] y
Related branches
lp:~rackspace-titan/glance/glance-user-confirm
- Jay Pipes (community): Approve
- Dan Prince (community): Approve
- Vish Ishaya (community): Approve
-
Diff: 53 lines (+21/-7)1 file modifiedbin/glance (+21/-7)
Revision history for this message
| Dan Prince (dan-prince) wrote | #1 |
Revision history for this message
| Édouard Thuleau (ethuleau) wrote | #2 |
| Changed in glance: | |
| assignee: | nobody → Brian Waldon (bcwaldon) |
| Changed in glance: | |
| importance: | Undecided → Medium |
| status: | New → Fix Committed |
| Changed in glance: | |
| milestone: | none → diablo-1 |
| Changed in glance: | |
| milestone: | diablo-1 → 2011.3 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Edouard,
I actually prefer the default to be 'no' when using 'glance clear' or 'glance delete'.
Should we simply change the text to '[y/N]' so that it is clear the default behaviour is no if the user just clicks enter?
In other words I like the existing behavior. I do however agree that the capital 'Y' makes you think yes would be the actual default.