postinst chown can fail
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| byobu (Ubuntu) |
Fix Released
|
High
|
Dustin Kirkland | ||
| Lucid |
Fix Released
|
High
|
Dustin Kirkland | ||
| Maverick |
Fix Released
|
High
|
Dustin Kirkland | ||
| Natty |
Fix Released
|
High
|
Dustin Kirkland | ||
| Oneiric |
Fix Released
|
High
|
Dustin Kirkland | ||
Bug Description
Binary package hint: byobu
<elmo> 16:46:26> Setting up byobu (2.68-0ubuntu1.1) ...
<elmo> 16:46:26> chown: invalid user: `asac'
<elmo> 16:46:33> thanks kirkland :-P
This needs to be handled more gracefully.
=======
SRU
- Impact: Upgrading users could experience a problem with Byobu's postinst, which touches a flag in each users' screen run directory. If a user's name has changed since their screen run directory was created at boot, then Byobu's chown procedure might fail. This is perhaps more likely to happen on long running uptime servers.
- How addressed: The chown command used in Byobu's postinst was ugly and naive. Instead, use chown --reference against the parent directory. Also, || true this command, as it's hardly essential to the package upgrade.
- How to reproduce: Create a test user, "foo". As user foo, start a byobu session. Exit that session. Rename user "foo" to "bar". Note that /var/run/S-foo still exists. Upgrade byobu. Byobu's postinst will touch /var/run/
- Regression potential: Patch is trivial, clean, regression potential is negligible.
- Minimal patch: http://
=======
| Changed in byobu (Ubuntu Oneiric): | |
| status: | New → In Progress |
| Changed in byobu (Ubuntu Natty): | |
| status: | New → Triaged |
| Changed in byobu (Ubuntu Maverick): | |
| status: | New → Triaged |
| Changed in byobu (Ubuntu Lucid): | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in byobu (Ubuntu Maverick): | |
| importance: | Undecided → High |
| Changed in byobu (Ubuntu Natty): | |
| importance: | Undecided → High |
| Changed in byobu (Ubuntu Oneiric): | |
| importance: | Undecided → High |
| Changed in byobu (Ubuntu Lucid): | |
| assignee: | nobody → Dustin Kirkland (kirkland) |
| Changed in byobu (Ubuntu Maverick): | |
| assignee: | nobody → Dustin Kirkland (kirkland) |
| Changed in byobu (Ubuntu Natty): | |
| assignee: | nobody → Dustin Kirkland (kirkland) |
| Changed in byobu (Ubuntu Oneiric): | |
| assignee: | nobody → Dustin Kirkland (kirkland) |
| status: | In Progress → Fix Committed |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in byobu (Ubuntu Oneiric): | |
| status: | Fix Committed → Fix Released |
| description: | updated |
| Changed in byobu (Ubuntu Lucid): | |
| status: | Triaged → Fix Committed |
| Changed in byobu (Ubuntu Maverick): | |
| status: | Triaged → Fix Committed |
| Changed in byobu (Ubuntu Natty): | |
| status: | Triaged → Fix Committed |
| Martin Pitt (pitti) wrote Please test proposed package | #2 |
| tags: | added: verification-needed |
| Martin Pitt (pitti) wrote | #3 |
| Martin Pitt (pitti) wrote | #4 |
| C de-Avillez (hggdh2) wrote | #5 |
| tags: | added: verification-done-natty |
| Dustin Kirkland (kirkland) wrote | #7 |
| tags: | added: verification-done |
| Launchpad Janitor (janitor) wrote | #8 |
| Changed in byobu (Ubuntu Natty): | |
| status: | Fix Committed → Fix Released |
| Clint Byrum (clint-fewbar) wrote | #9 |
| tags: | removed: verification-done-lucid verification-done-natty verification-needed |
| Launchpad Janitor (janitor) wrote | #10 |
| Changed in byobu (Ubuntu Maverick): | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #11 |
| Changed in byobu (Ubuntu Lucid): | |
| status: | Fix Committed → Fix Released |
This bug was fixed in the package byobu - 4.11-0ubuntu1
---------------
byobu (4.11-0ubuntu1) oneiric; urgency=low
[ Dustin Kirkland ]
* debian/postinst: LP: #796422
- handle ownerships of the reload profile flag more gracefully
[ Ahmed El-Mahmoudy ]
* usr/share/
- fix refresh keybinding (missing eval)
-- Dustin Kirkland <email address hidden> Sat, 11 Jun 2011 09:42:07 -0400