plugins.ini should be collapsed into quantum.conf to prevent configuration"sprawl"

Bug #803086 reported by Somik Behera
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Salvatore Orlando

Bug Description

We have two distinct file for Quantum API service configuration (default: /etc/quantum.conf) and for specifying the plugin (default ./plugins.ini). Plugins.ini at the moment only specifies the class of the quantum plugin.

It seems this information can be easily moved into quantum.conf.

To prevent configuration sprawl, we should collapse these two files.

Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

In lp:~netstack/quantum/quantum-unit-test I have made some changes to allow configuration options to the plugins.
Maybe this mechanisms can be leveraged for fixing this bug.

Changed in quantum:
importance: Undecided → Medium
Revision history for this message
dan wendlandt (danwent) wrote :

Note: let's NOT tackle this prior to the diablo release, as it is too late in the game to mess with something so fundamental.

Changed in quantum:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
Changed in quantum:
milestone: none → essex-1
Changed in quantum:
status: New → In Progress
Revision history for this message
Brad Hall (bgh) wrote :

Can we target this for essex-2 please? Too late in the cycle to be changing this stuff.

Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Untargeting following review on patches. Considering that we are relying on plugins.ini in several places outside of quantum, I would consider leaving plugins.ini where it is, and marking this bug as invalid.

Having a single configuration file would probably be more 'elegant', but having both quantum.conf and plugins.ini will not be too much of an issue.

Changed in quantum:
milestone: essex-1 → none
dan wendlandt (danwent)
Changed in quantum:
milestone: none → essex-2
Revision history for this message
dan wendlandt (danwent) wrote :

Man, this feature is the king of getting bumped. Let's do it E-3 for real.

My concern with the existing implementation is that if someone is unaware that there is a new way to configure the plugin, and they only change the plugins.ini, it seems like the plugin specified in the quantum.conf is still used.

We probably need to talk more about this.

Changed in quantum:
milestone: essex-2 → essex-3
Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

The branch has been languishing on gerrit for a while now, and we are approaching Essex-3.
Since this is a change which might have unexpected effects, we said in the past we wanted to avoid merging it close to a milestone release.
Is Essex-3 still a good target, or should we postpone it to E-4 or F?

summary: plugins.ini should be collapsed into quantum.conf to prevent
- configuraitn"sprawl"
+ configuration"sprawl"
Revision history for this message
dan wendlandt (danwent) wrote :

If it really just needs review, let's still push it for E-3, assuming we have the backward compatibility right. If more work is required and we are short on cycles, E-4 is ok.

I'm assuming we want the following backward compatibility behavior:

1) if someone sets the plugin using the "old" mechanism (i.e., only knows about changing plugins.ini), then this should still work.
2) if someone knows about the "new" mechanism (i.e., sets it in quantum.conf, does not modify plugins.ini), then this should work.

I think when i tested out this patch a while back, #1 above did not work. Was I doing something incorrectly?

Revision history for this message
dan wendlandt (danwent) wrote :

sigh.... for real... this is going to be in E-4. For real :)

Changed in quantum:
milestone: essex-3 → essex-4
Revision history for this message
dan wendlandt (danwent) wrote :

sigh....

we should just make this change for folsom, backward compat be damned.

Changed in quantum:
milestone: essex-4 → none
Revision history for this message
Gary Kotton (garyk) wrote :

This issue is addressed in the common-cfg blueprint (https://blueprints.launchpad.net/quantum/+spec/use-common-cfg). The plugin.ini file was merged into the quantum.conf.
I do not think that backward compatability is an issue here and the quantum installation scripts (ubuntu, fedora et al) should deal with this.

Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Looking at garyk comment, it seems we can finally close this bug.
Please tell me we can!

Revision history for this message
dan wendlandt (danwent) wrote :

hooray!

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → folsom-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.