Launchpad itself

copyPackage only includes changes from upload being copied

Bug #827576 reported by Iain Lane
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Julian Edwards

Bug Description

Hi,

Sometimes copied packages have multiple uploads between the source and target release. If I use copyPackage to copy these, the generated changes only contain the most recent ones. See

  https://launchpad.net/ubuntu/+source/mono/2.10.4-2

for an example. There were two uploads between 2.10.3-1 and 2.10.4-2 which was copied, but the changes from 2.10.4-1 weren't included. Launchpad did know about -1

  https://launchpad.net/debian/+source/mono/+publishinghistory

If I were making a changesfile, I'd pass -v2.10.3-1 and then dpkg-genchanges would include the changelog entries which are strictly newer than 2.10.3-1. It's important that uploads contain the complete history.

Cheers,
Iain

Related branches

lp:~julian-edwards/launchpad/changelogs-bug-827576
William Grant: Approve (code)
Jeroen T. Vermeulen (community): Approve
Diff: 557 lines (+254/-47)
9 files modified
lib/lp/soyuz/adapters/notification.py (+17/-11)
lib/lp/soyuz/adapters/tests/test_notification.py (+58/-21)
lib/lp/soyuz/interfaces/archive.py (+3/-1)
lib/lp/soyuz/interfaces/sourcepackagerelease.py (+11/-0)
lib/lp/soyuz/model/sourcepackagerelease.py (+43/-0)
lib/lp/soyuz/scripts/packagecopier.py (+13/-1)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+69/-9)
lib/lp/soyuz/tests/test_sourcepackagerelease.py (+27/-0)
lib/lp/testing/factory.py (+13/-4)
Launchpad Janitor (janitor)
Changed in launchpad:
status: New → Confirmed
Colin Watson (cjwatson)
tags: added: derivation
Aaron Bentley (abentley)
Changed in launchpad:
importance: Undecided → High
Revision history for this message
Julian Edwards (julian-edwards) wrote :

I expect this applies to the web interface too.

Changed in launchpad:
status: Confirmed → Triaged
Revision history for this message
Julian Edwards (julian-edwards) wrote :

<cjwatson> FWIW I phrased my dup of the bug quite carefully - I don't believe it's necessary for /ubuntu/+source/SRC/COPIED-VERSION to show the aggregated changelog, only the stuff that's mailed out
<cjwatson> Iain didn't put it that way, but I strongly suspect he'd be fine with just fixing the announcement mails

Revision history for this message
Colin Watson (cjwatson) wrote :

FWIW I think it would be fine if just the announcement mails had the aggregated changelog entries. I went into more detail in bug 827577 (duplicate).

Revision history for this message
Iain Lane (laney) wrote :

I think it would be slightly annoying if +changelog didn't contain the complete changelog, but I understand why technically it wouldn't be good to do that.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

We can probably snag the code from sync-source that does this; so it's not as bad as I feared.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

The changes entries are built in lib/lp/soyuz/adapters/notification.py / fetch_information() by snagging the changelog_entry from the passed SPR.

This method is called many times in the notification code, it needs refactoring and its results caching. When we have a separate function that calculates the changes, we can pass in a previous_version so it returns an aggregated changes log.

Julian Edwards (julian-edwards)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Julian Edwards (julian-edwards)
Revision history for this message
Iain Lane (laney) wrote :

Will this close LP bugs given in the changelog?

Revision history for this message
Julian Edwards (julian-edwards) wrote :

This change won't, but I am doing a followup to it that will. Actually I thought there was a bug for this already but I can't find one.

Revision history for this message
Stefano Rivera (stefanor) wrote :

> Actually I thought there was a bug for this already but I can't find one.

It wasn't filed, only mentioned in LP: #830584. I've filed LP: #833736

Julian Edwards (julian-edwards)
tags: added: qa-bad
tags: added: bad-commit-13798
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13798 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13798>.

tags: added: qa-needstesting
removed: qa-bad
Changed in launchpad:
status: In Progress → Fix Committed
Julian Edwards (julian-edwards)
tags: added: qa-bad
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13826 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13826>.

tags: added: qa-needstesting
removed: qa-bad
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Julian Edwards (julian-edwards)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.