get_instance_type don't handle exception.InstanceTypeNotFound

Bug #872618 reported by Nachi Ueno
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Maru Newby
OpenStack Quality Assurance
Fix Released
Medium
Unassigned

Bug Description

get_instance_type and get_default_instance_type in instance_types.py don't handle exception.InstanceTypeNotFound.
This exception must be handled and then this class should produce APIError.

Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Low
status: New → Confirmed
Nachi Ueno (nati-ueno)
Changed in nova:
assignee: nobody → Nachi Ueno (nati-ueno)
Changed in openstack-qa:
assignee: nobody → Nachi Ueno (nati-ueno)
status: New → In Progress
importance: Undecided → Medium
Changed in nova:
status: Confirmed → In Progress
Nachi Ueno (nati-ueno)
Changed in nova:
assignee: Nachi Ueno (nati-ueno) → nobody
Changed in openstack-qa:
assignee: Nachi Ueno (nati-ueno) → nobody
Ken Pepple (ken-pepple)
Changed in nova:
assignee: nobody → Ken Pepple (ken-pepple)
Maru Newby (maru)
Changed in nova:
assignee: Ken Pepple (ken-pepple) → Maru Newby (maru)
Revision history for this message
Thierry Carrez (ttx) wrote :

Obviously not in progress, unassigning so that someone else can have a shot at it.

Changed in nova:
assignee: Maru Newby (maru) → nobody
status: In Progress → Confirmed
Maru Newby (maru)
Changed in nova:
assignee: nobody → Maru Newby (maru)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/3706

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/3706
Committed: http://github.com/openstack/nova/commit/07d74aa916ee2798f717ae5d298f8ca51e883770
Submitter: Jenkins
Branch: master

commit 07d74aa916ee2798f717ae5d298f8ca51e883770
Author: Maru Newby <email address hidden>
Date: Thu Feb 2 12:52:10 2012 -0800

    Raise ApiError in response to InstanceTypeNotFound

     * Updates methods in nova.compute.instance_types to catch
       InstanceTypeNotFound exceptions and re-raise them as ApiError.
       - Previously, the methods in instance_types were raising ApiError in
         response to DBError, but the underlying db calls have since been
         updated to detect empty results and throw more specific exceptions.
     * Updates get_instance_type_by_flavor_id to not try to catch DBError,
       as the underlying db call only ever raises FlavorNotFound.
       get_instance_type_by_flavor_id should not raise ApiError, as callers
       expect the FlavorNotFound exception and know how to handle it.
     * Fixes bug 872618

    Change-Id: I8652f04889adb448017afd253ecdcc840fbb660f

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
Nachi Ueno (nati-ueno)
Changed in openstack-qa:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.