instance_update with uuid as instance_Id and metadata fails

Bug #887712 reported by Nachi Ueno
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Unassigned

Bug Description

instance_update check's instance_Id is uuid or not.Then if the instance_id is uuid, this method use instance_get_by_uuid.
However this method didn't check this for instance_metadata_update which doesn't accept uuid.

https://github.com/openstack/nova/blob/stable/diablo/nova/db/sqlalchemy/api.py#L1546

Nachi Ueno (nati-ueno)
Changed in openstack-qa:
assignee: nobody → Nachi Ueno (nati-ueno)
status: New → Confirmed
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Nachi Ueno (nati-ueno) wrote :
tags: added: forward-port-needed
Changed in openstack-qa:
status: Confirmed → In Progress
Nachi Ueno (nati-ueno)
Changed in openstack-qa:
assignee: Nachi Ueno (nati-ueno) → nobody
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/1926
Committed: http://github.com/openstack/nova/commit/9f643c80c6357805f591c822a2042367728c5780
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 9f643c80c6357805f591c822a2042367728c5780
Author: Adrian Smith <email address hidden>
Date: Wed Nov 16 09:21:35 2011 +0000

    Fix for bug 887712

    Check weather the instance_id passed into instance_update() is a model id
    or a UUID.

    Change-Id: Ic361299cdbfa5c3786815753c47a8e4f3ba6d494

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Nachi, can you please verify that the committed fix addresses this bug?

Brian Waldon (bcwaldon)
Changed in nova:
status: Confirmed → Fix Committed
no longer affects: openstack-qa
Changed in nova:
milestone: none → 2012.1
Thierry Carrez (ttx)
Changed in nova:
milestone: 2012.1 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.