GtkCellRendererText "edited" signal not emitted when clicking out of cell

Bug #898114 reported by Murray Cumming
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTK+
Fix Released
Medium
gtk+3.0 (Ubuntu)
Fix Released
High
Unassigned
Oneiric
Fix Released
High
Unassigned

Bug Description

With older versions of GTK+ 3, before 3.2.1.

From https://bugzilla.gnome.org/show_bug.cgi?id=653289
"
With GTK+ 3 (at least with git master), GtkCellRendererText's "edited" signal
is not emitted when I click into the next cell in the treeview. It is
apparently only emitted when I press return.

This is not a problem with GTK+ 2.24.

You can see this, for instance, in GtkFileChooserDialog when creating a new
folder. Your new name for the folder will be lost if you click away instead of
typing Enter.

It also happens in Nautilus when renaming files.
"

I consider this to be a data loss bug.

Revision history for this message
Murray Cumming (murrayc) wrote :

Note that the upstream bug has a simple fix for this, though I'd rather that Ubuntu Oneiric was just updated to the latest stable GTK+ release instead of applying an individual patch.
https://bugzilla.gnome.org/show_bug.cgi?id=653289#c12

summary: - GtkCellRendererText "edited" signal not emitted when clicking out of cel
+ GtkCellRendererText "edited" signal not emitted when clicking out of
+ cell
Revision history for this message
Murray Cumming (murrayc) wrote :

Marking as Fix Released because this is fixed in Ubuntu Precise because that has a newer version of GTK+.

affects: gtk+3.0 (Ubuntu) → ubuntu
Changed in ubuntu:
status: New → Fix Released
Revision history for this message
Murray Cumming (murrayc) wrote :

Trying to follow the procedure from here:
https://wiki.ubuntu.com/StableReleaseUpdates

[Impact]
This causes loss of data in applications that use GtkTreeViews to edit data. If the user is unlucky then he will not even notice. It's most obvious impact is in the GTK+ file chooser when creating a directory, and in Nautilus when renaming files. The new file names are lost unless the user explicitly types Enter. This was a regression compared to GTK+ 2.

[Development Fix]
Ubuntu Precise does not have this problem because it has a later version of GTK+ that includes the fix. GTK+ fixed this in a stable bug-fix release.

[Stable Fix]
This patch fixed it upstream:
https://bugzilla.gnome.org/show_bug.cgi?id=653289#c12

[Test Case]
In the Nautilus file manager, right-click a file and choose "Rename ...". Change the file name. Click on a different file. The new file name will be lost. It will only be retained if you press Enter instead of clicking away.

[Regression Potential]
This fix has been upstream for a long time now and no problems have been reported.

Revision history for this message
Anders Kaseorg (andersk) wrote :

(Is there some Launchpad bug that keeps changing the Package from gtk+3.0 to none? Maybe an escape() or encodeURI() that should be an encodeURIComponent()?)

affects: ubuntu → gtk+3.0 (Ubuntu)
Changed in gtk:
importance: Unknown → Medium
status: Unknown → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :
Changed in gtk+3.0 (Ubuntu Oneiric):
importance: Undecided → High
Changed in gtk+3.0 (Ubuntu):
importance: Undecided → High
Changed in gtk+3.0 (Ubuntu Oneiric):
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

I uploaded that patch to oneiric-proposed, awaiting ubuntu-sru review now.

Changed in gtk+3.0 (Ubuntu Oneiric):
status: Triaged → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Murray, or anyone else affected,

Accepted gtk+3.0 into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote :

Could anyone please test the version in -proposed? Thank you!

Revision history for this message
Christopher Townsend (townsend) wrote :

Following the test case in comment #3, I'm able to verify that 3.2.0-0ubuntu6 does fix the issue.

Revision history for this message
Murray Cumming (murrayc) wrote :

I too can confirm that it fixes the Nautilus renaming problem.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.2.0-0ubuntu6

---------------
gtk+3.0 (3.2.0-0ubuntu6) oneiric-proposed; urgency=low

  * Add git_push_error_traps_around_xiquerydevice_calls.patch:
    git backport to handle session errors after suspend/resume. This may help
    against the crashes at resume time that some people have been hitting when
    input devices mysteriously disappear. (LP: #882956)

gtk+3.0 (3.2.0-0ubuntu5) oneiric-proposed; urgency=low

  * Add git_cell_area_editing.patch: Fix signal emission for cell areas when
    clicking a different widget after editing. Patch backported from newer GTK
    versions. (LP: #898114)
 -- Ayan George <email address hidden> Fri, 03 Feb 2012 12:02:39 -0500

Changed in gtk+3.0 (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.