neutron

quantumclient setup.py lies about dependencies

Bug #921933 reported by Paul McMillan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Maru Newby
neutron 2012.2 "folsom"

Bug Description

quantumclient claims to require a number of packages in its setup.py. It turns out, only python-gflags is necessary (the one reference to webob is bug 921930). The others should be removed.

https://github.com/openstack/python-quantumclient/blob/master/setup.py#L63

See original description
Paul McMillan (paul-mcmillan)
description: updated
Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

That is true in my opinion.
However paste is used by quantum.common.config.py. This module is misplaced into the client, as it belongs to the server.

Revision history for this message
dan wendlandt (danwent) wrote :

I am in favor of going through quantum.common and moving what is only used by the server out of quantum.common and into the server repo.

I would even go as far to say that assuming there is little left over in common (serializers, some exceptions?) that it may make sense to see if we even split the code entirely (with minor duplication if needed) so we can get rid of this really confusing dependency. I think it is something that will continue to make life hard on new developers.

Maru Newby (maru)
Changed in quantum:
assignee: nobody → Maru Newby (maru)
OpenStack Infra (hudson-openstack)
Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-quantumclient (master)

Reviewed: https://review.openstack.org/6450
Committed: http://github.com/openstack/python-quantumclient/commit/05c5a2b4a9b0eb9c0bf88cd81390c7bc906bd289
Submitter: Jenkins
Branch: master

commit 05c5a2b4a9b0eb9c0bf88cd81390c7bc906bd289
Author: Maru Newby <email address hidden>
Date: Wed Apr 11 02:20:57 2012 -0700

    Remove server-specific functionality.

     * Moved server-specific functionality found in quantum.common to
       the quantum repo.
     * Renamed primary package from quantum -> quantumclient.
     * Addresses bug 977711 and bug 921933

    Change-Id: If34553924c8dfcc6b148c1d91f173a4b81eeb95a

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → folsom-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.