responses fail when image cache fails

Bug #929762 reported by Mark Washenberger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Mark Washenberger

Bug Description

When I accidentally configured glance image cache with a higher limit than the filesystem would support, responses would fail in odd ways. Here's the traceback I saw in glance api logs

2012-02-08 21:20:42 23377 DEBUG [eventlet.wsgi.server] Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/eventlet/wsgi.py", line 347, in handle_one_response
    for data in result:
  File "/usr/lib/python2.6/dist-packages/glance/image_cache/__init__.py", line 227, in tee_iter
    cache_file.flush()
  File "/usr/lib/python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)
  File "/usr/lib/python2.6/dist-packages/glance/image_cache/drivers/sqlite.py", line 329, in open_for_write
    yield cache_file
  File "/usr/lib/python2.6/dist-packages/glance/image_cache/__init__.py", line 225, in tee_iter
    cache_file.write(chunk)
IOError: [Errno 28] No space left on device

I understand that one shouldn't misconfigure glance, but it would be nice if a cache failure didn't kill the whole response.

Changed in glance:
assignee: nobody → Mark Washenberger (markwash)
status: New → In Progress
Jay Pipes (jaypipes)
Changed in glance:
milestone: none → essex-4
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/3974
Committed: http://github.com/openstack/glance/commit/481929b5c5dbca90762fe339e9e3224f7628ce2a
Submitter: Jenkins
Branch: master

commit 481929b5c5dbca90762fe339e9e3224f7628ce2a
Author: Mark Washenberger <email address hidden>
Date: Thu Feb 9 12:59:49 2012 -0500

    Don't fail response if caching failed

    Fixes bug 929762

    Change-Id: I90761b69cc556b14fd4bdb931541804244b653e8

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.