VM

Upgrading attributes should not set buffer-modified

Bug #932602 reported by Uday Reddy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VM
Fix Committed
Medium
Uday Reddy
VM 8.2.90a

Bug Description

Julian Bradfield writes (viewmail-info, 2012-02-14):

If I visit a folder read-only, I don't expect it to be changed and
written back to disk. However, this happens:

(a) If I visit a folder created by my MTA, VM says "upgrading
    attributes", and then the folder is modified, and VM writes it
    back to disk when I quit. This of course causes corruption if the
    MTA is writing new mail at the same time, since they use different
    locking mechanisms.

Tags: 8.2 folders

Related branches

lp:vm
Revision history for this message
Uday Reddy (reddyuday) wrote :

We can discuss assigning a strong semantics to read-only, but I suspect that
it may be difficult to implement. "Upgrading attributes", for example,
needs to be done when an old folder is read because the new code base will
only work with the upgraded version of data. We can perhaps refrain from
writing the folder back to the disk at the end if the read-only flag is set.

Revision history for this message
Uday Reddy (reddyuday) wrote :

John Hein:

In fact, I think I would prefer that for read-write folders that have
old attributes. That is, update the attributes in memory and don't
mark the folder changed for just folder attribute changes. Then if
you don't make any other changes and then do vm-quit or
vm-quit-no-change, vm just quits the folder without saving the updated
attributes (and without asking you to save the [internal] folder
attributes change). If you do make "real" changes, then vm saves the
updated attributes along with those changes.

Revision history for this message
Uday Reddy (reddyuday) wrote :

Yes, this behaviour has changed from 8.1.1 to 8.2.0. The old code was not
marking the buffer as modified. I will reset it back to the old way.

Revision history for this message
Uday Reddy (reddyuday) wrote :

Fix committed in rev. 1364.

Changed in vm:
status: Triaged → Fix Committed
Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.2.89a → 8.2.0b1
no longer affects: vm/8.2.x
Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.2.1a → 8.2.0
Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.2.1a → 8.2.90a
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.