Service names are double-quoted

Bug #943523 reported by justinsb
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Dean Troyer
devstack
Fix Released
Medium
Dean Troyer

Bug Description

With devstack, the service names are double quoted - there's a single quote inside the double quote(see below).

I think it's a keystone bug because this seems to come from etc/default_catalog.templates. However, this will probably also need to be fixed in devstack afterwards.

{"access":... "serviceCatalog": [{"endpoints": [{... "type": "compute", "name": "'Compute Service'"},...

Revision history for this message
Dolph Mathews (dolph) wrote :

I noticed this as well.

Changed in keystone:
status: New → Confirmed
Joseph Heck (heckj)
Changed in keystone:
importance: Undecided → Medium
Revision history for this message
Jesse Andrews (anotherjesse) wrote :

I assume this is a devstack bug - not keystone

Changed in devstack:
assignee: nobody → Dean Troyer (dtroyer)
Dean Troyer (dtroyer)
Changed in devstack:
importance: Undecided → Medium
Revision history for this message
Dean Troyer (dtroyer) wrote :

It's a bug in both (if a sample config file can have a bug). The template parser doesn't do any quote interpolation, just splits on ' = ' and passes the two parts on. So we just remove the quotes for now.

Changed in keystone:
assignee: nobody → Dean Troyer (dtroyer)
Changed in devstack:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5242

Changed in devstack:
status: Confirmed → In Progress
Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5243

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/5243
Committed: http://github.com/openstack/keystone/commit/a036b3f77ba39301d0a5d44afe6c4253c0db8b15
Submitter: Jenkins
Branch: master

commit a036b3f77ba39301d0a5d44afe6c4253c0db8b15
Author: Dean Troyer <email address hidden>
Date: Mon Mar 12 14:45:34 2012 -0500

    Fix double-quoted service names

    The Keystone service template parser doesn't do any quote interpolation,
    it just splits on ' = ' and passes the two parts on. So we just remove
    the quotes for now.

    Fixes bug 943523

    Change-Id: Ib9e17e70926339ab67f9c50a52a5036eeb7bfb65

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/5242
Committed: http://github.com/openstack-dev/devstack/commit/06a09d0c33f0626379cad377b4ffa20fcda54858
Submitter: Jenkins
Branch: master

commit 06a09d0c33f0626379cad377b4ffa20fcda54858
Author: Dean Troyer <email address hidden>
Date: Mon Mar 12 14:43:26 2012 -0500

    Fix double-quoted service names

    The Keystone service template parser doesn't do any quote interpolation,
    it just splits on ' = ' and passes the two parts on. So we just remove
    the quotes for now.

    Fixes bug 943523

    Change-Id: Ia2a10ec18db1a82f23f36200b0cdef84b4f78155

Changed in devstack:
status: In Progress → Fix Committed
Dean Troyer (dtroyer)
Changed in devstack:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → essex-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.