Light Display Manager

GIR interface is not following the documentation of the constructor

Bug #990490 reported by Nadav on 2012-04-28

This bug affects 1 person

	Status	Importance	Assigned to
Light Display Manager	Fix Released	High	Unassigned
lightdm (Ubuntu)	Fix Released	High	salomon peralta lopez
Oneiric	Fix Released	High	Unassigned

Bug Description

I try to create greeter in JS and it complain that the constructor of
LightDM.Greeter need args while in the documentation is not.

let greeter = new LightDM.Greeter();

    JS ERROR: !!! Exception was: Error: Unable to construct boxed type
Greeter since it has no zero-args <constructor>, can only wrap an existing
one
    JS ERROR: !!! lineNumber = '0'
    JS ERROR: !!! fileName = '"gjs_throw"'
    JS ERROR: !!! stack = '"("Unable to construct boxed type Greeter
since it has no zero-args <constructor>, can only wrap an existing
one")@gjs_throw:0
@./main.js:7
"'
    JS ERROR: !!! message = '"Unable to construct boxed type Greeter
since it has no zero-args <constructor>, can only wrap an existing one"'
Error: Unable to construct boxed type Greeter since it has no zero-args
<constructor>, can only wrap an existing one

Based on documentation:
http://people.ubuntu.com/~robert-ancell/lightdm/reference/lightdm-gobject-1-Greeter-Interface.html

original post in mailing list:
http://lists.freedesktop.org/archives/lightdm/2012-April/000262.html

Tags:

Related branches

lp:ubuntu/oneiric-proposed/lightdm

lp:ubuntu/oneiric-updates/lightdm

Robert Ancell (robert-ancell) on 2012-04-29

Changed in lightdm:
status:	New → Triaged
importance:	Undecided → High

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2012-04-30:

What Javascript engine are you running through? Can you give a step by step way to reproduce this?

Revision history for this message

Nadav (nadavvin) wrote on 2012-04-30:

example for lightdm js Edit (90 bytes, application/x-javascript)

Ubuntu 11.10
gir1.2-lightdm-1
gjs

$ gjs
gjs> const LightDM = imports.gi.LightDM;
typein:1: strict warning: reference to undefined property imports.gi
typein:1: strict warning: reference to undefined property imports.gi.LightDM
gjs> let greeter = new LightDM.Greeter();
typein:2: strict warning: reference to undefined property LightDM.Greeter
Error: Unable to construct boxed type Greeter since it has no zero-args <constructor>, can only wrap an existing one

attached example code

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2012-05-01:

Nadav, could you try the version in this PPA:
https://launchpad.net/~lightdm-team/+archive/test

Thanks.

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2012-05-01:

This works for me in Ubuntu 12.04, it appears the problem is the GIR bindings are broken and this was fixed in lightdm 1.1.2. The PPA version has this backported.

Revision history for this message

Nadav (nadavvin) wrote on 2012-05-02:

It's work on the version in the PPA

Revision history for this message

Clint Byrum (clint-fewbar) wrote on 2012-05-03:

Hi! Please add an Impact/Test Case/Regression Potential section to the bug description, per https://wiki.ubuntu.com/StableReleaseUpdates

The upload looks fine, but please add those sections and then the upload can be accepted into oneiric-proposed.

Thanks!

Changed in lightdm (Ubuntu):
status:	New → Fix Released
importance:	Undecided → High
Changed in lightdm (Ubuntu Oneiric):
status:	New → Fix Committed
importance:	Undecided → High

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2012-05-03:

Impact - GIR bindings do not work in Oneiric
Development Fix - But was fixed in lightdm 1.1.2 by fixing build rules for GIR generation and correcting one GIR annotation. This fix has been backported.
Stable Fix - debian/patches/13_fix_gir_bindings.patch
Test Case - Run the program in comment 2. It should not generate an error.
Regression Potential - Nothing was using the GIR bindings in Oneiric and this bug shows they weren't working. The patch only changes the GIR generation so should not change any other aspect of the program.

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2012-05-03:

13_fix_gir_bindings.patch Edit (1.5 KiB, text/plain)

Revision history for this message

Martin Pitt (pitti) wrote on 2012-05-04: Please test proposed package

Hello Nadav, or anyone else affected,

Accepted lightdm into oneiric-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags:

added: verification-needed

Revision history for this message

Jonathan Reed (jdreed) wrote on 2012-06-04:

#10

lightdm and its gir bindings in oneiric-proposed (1.0.6-0ubuntu1.7) work fine for me, both with the JavaScript test case above, and my project's own LightDM greeter written in Python. Can this please get pushed to production?

tags:

removed: verification-needed

Sebastien Bacher (seb128) on 2012-06-05

tags:

added: verification-done

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-06-07:

#11

This bug was fixed in the package lightdm - 1.0.6-0ubuntu1.7

---------------
lightdm (1.0.6-0ubuntu1.7) oneiric-proposed; urgency=low

* debian/patches/13_fix_gir_bindings.patch:
- Fix GIR bindings (LP: #990490)
-- Robert Ancell <email address hidden> Tue, 01 May 2012 10:45:07 +1200