'Total active time' keeps increasing when a task is done

Bug #992854 reported by Bryce Harrington
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
task (Ubuntu)
Fix Released
Medium
Bryce Harrington
Precise
Fix Released
Medium
Bryce Harrington

Bug Description

[Impact]
The value 'Total active time' returned by 'task info' continues to increase when a task have been done without being stopped.

[Development Fix]
The issue was fixed upstream. This fix has been backported to the 2.0.0 version and uploaded to quantal

[Stable Fix]
Since we're including essentially the same version of task in precise and quantal, the same patch can be included in quantal.

[Test Case]
$ task add Test
Created task 41.
$ task 1 start
Starting task 1 'Test'.
Started 1 task.
$ task 1 done
Completed task 41 'Test'.
Completed 1 task.
$ task 9c47cff1 info | grep "Total active time"
Total active time 0:00:19
$ task 9c47cff1 info | grep "Total active time"
Total active time 0:00:21

Upstream bug: http://taskwarrior.org/issues/987

[Regression Potential]
None expected. The patch merely adds to the test of an if condition, and is short enough to verify correctness by review. There are no changes involving pointers. So, regressions would be limited to behavioral changes for the info command.

Revision history for this message
Bryce Harrington (bryce) wrote :

Fixed in this upstream commit:

commit b4d09d1c308fdc956798d830e09b7193a111e6c0
Author: Louis-Claude Canon <email address hidden>
Date: Tue Apr 24 23:36:04 2012 -0400

    Bug #987

    - Fixed bug #987, so that total active time does not continue to accumulate
      after an active task is completed.

    Signed-off-by: Paul Beckingham <email address hidden>

description: updated
Changed in task (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Bryce Harrington (bryce)
Changed in task (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package task - 2.0.0.release-0ubuntu4

---------------
task (2.0.0.release-0ubuntu4) quantal; urgency=low

  * Add 103_total_active_time.patch: Don't continue accumulating total
    active time after an active task is completed.
    (LP: #992854)
  * Add 104_project_complete_verbosity.patch and 105_affected_verbosity.patch:
    Be quieter with feedback if rc.vebose=nothing is specified.
    (LP: #992876)
  * Add 106_chdir_back_after_edit.patch: Fix segfault in
    Context::dispatch() when running task shell. This is because the edit
    command was not restoring the current directory.
    (LP: #980093)
 -- Bryce Harrington <email address hidden> Thu, 19 Jul 2012 14:43:49 -0700

Changed in task (Ubuntu):
status: Fix Committed → Fix Released
Bryce Harrington (bryce)
Changed in task (Ubuntu Precise):
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Bryce Harrington (bryce)
Changed in task (Ubuntu):
assignee: nobody → Bryce Harrington (bryce)
description: updated
Revision history for this message
Stéphane Graber (stgraber) wrote :

Reverting the precise task to In Porogress, Fix Commited is for packages that are in the -proposed pocket, this package is still in the Unapproved queue.

Changed in task (Ubuntu Precise):
status: Fix Committed → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Bryce, or anyone else affected,

Accepted task into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/task/2.0.0.release-0ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in task (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
tags: added: verification-done
removed: verification-needed
Revision history for this message
Bryce Harrington (bryce) wrote :

Yep, looks good.

Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package task - 2.0.0.release-0ubuntu2.2

---------------
task (2.0.0.release-0ubuntu2.2) precise-proposed; urgency=low

  * Add 103_total_active_time.patch: Don't continue accumulating total
    active time after an active task is completed.
    (LP: #992854)
  * Add 104_project_complete_verbosity.patch and 105_affected_verbosity.patch:
    Be quieter with feedback if rc.vebose=nothing is specified.
    (LP: #992876)
  * Add 106_chdir_back_after_edit.patch: Fix segfault in
    Context::dispatch() when running task shell. This is because the edit
    command was not restoring the current directory.
    (LP: #980093)
 -- Bryce Harrington <email address hidden> Thu, 19 Jul 2012 14:43:49 -0700

Changed in task (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.