light-themes

Merge lp:~mitya57/light-themes/panel-fixes-part-1 into lp:~ubuntu-art-pkg/light-themes/trunk

  1. panel-fixes-part-1
  2. Merge into trunk
Proposed by Dmitry Shachnev
Status: Merged
Merged at revision: 214
Proposed branch: lp:~mitya57/light-themes/panel-fixes-part-1
Merge into: lp:~ubuntu-art-pkg/light-themes/trunk
Diff against target: 79 lines (+29/-0)
2 files modified
Ambiance/gtk-3.0/apps/gnome-panel.css (+15/-0)
Radiance/gtk-3.0/apps/gnome-panel.css (+14/-0)
To merge this branch: bzr merge lp:~mitya57/light-themes/panel-fixes-part-1
Reviewer Review Type Date Requested Status
Andrea Cimitan Approve
Ubuntu Artwork Packagers Pending
Review via email: mp+95781@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Whoops, I specified wrong gradient for Ambiance separator, hope to fix this later tonight.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

OK to merge now, patch from bug 920832 needs merging together with this.

lp:~mitya57/light-themes/panel-fixes-part-1 updated
213. By Dmitry Shachnev

Fix low-contrast labels in window list (LP: #828392)

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Fixed the most annoying issue, now it should be perfect :)

Revision history for this message
Andrea Cimitan (cimi) wrote :

Tested with unity, seems to be working fine, merging

Revision history for this message
Andrea Cimitan (cimi) :
review: Approve
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

@Andrea: some unrelated questions:

- Why do we still carry gtk-2 theming for gnome apps? Can it be dropped?
- Why do we have most of the gnome-terminal theming commented out? Are there any plans to revert it?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.0/apps/gnome-panel.css'
2--- Ambiance/gtk-3.0/apps/gnome-panel.css 2012-02-08 12:55:19 +0000
3+++ Ambiance/gtk-3.0/apps/gnome-panel.css 2012-03-06 15:14:22 +0000
4@@ -10,6 +10,18 @@
5 color: @dark_fg_color;
6 }
7
8+PanelApplet {
9+ border-width: 0;
10+}
11+
12+PanelSeparator {
13+ border-width: 0;
14+ background-image: -gtk-gradient (linear, left top, left bottom,
15+ from (shade (@dark_bg_color, 1.5)),
16+ to (shade (@dark_bg_color, 1.05)));
17+ color: @dark_fg_color;
18+}
19+
20 .gnome-panel-menu-bar,
21 PanelApplet > GtkMenuBar.menubar,
22 PanelApplet > GtkMenuBar.menubar.menuitem,
23@@ -25,15 +37,18 @@
24 background-image: -gtk-gradient (linear, left top, left bottom,
25 from (shade (@dark_bg_color, 1.5)),
26 to (shade (@dark_bg_color, 1.05)));
27+ border-width: 0;
28 }
29
30 PanelApplet .button {
31 background-image: -gtk-gradient (linear, left top, left bottom,
32 from (shade (@dark_bg_color, 1.5)),
33 to (shade (@dark_bg_color, 1.05)));
34+ color: @dark_fg_color;
35 border-color: shade (@dark_bg_color, 0.78);
36 border-radius: 0;
37 border-width: 0 1px 0 1px;
38+ -GtkButton-inner-border: 2;
39
40 text-shadow: none;
41
42
43=== modified file 'Radiance/gtk-3.0/apps/gnome-panel.css'
44--- Radiance/gtk-3.0/apps/gnome-panel.css 2012-02-08 12:55:19 +0000
45+++ Radiance/gtk-3.0/apps/gnome-panel.css 2012-03-06 15:14:22 +0000
46@@ -10,6 +10,18 @@
47 color: @dark_fg_color;
48 }
49
50+PanelApplet {
51+ border-width: 0;
52+}
53+
54+PanelSeparator {
55+ border-width: 0;
56+ background-image: -gtk-gradient (linear, left top, left bottom,
57+ from (shade (@dark_bg_color, 1.15)),
58+ to (shade (@dark_bg_color, 0.95)));
59+ color: @dark_fg_color;
60+}
61+
62 .gnome-panel-menu-bar,
63 PanelApplet > GtkMenuBar.menubar,
64 PanelApplet > GtkMenuBar.menubar.menuitem,
65@@ -25,6 +37,7 @@
66 background-image: -gtk-gradient (linear, left top, left bottom,
67 from (shade (@dark_bg_color, 1.15)),
68 to (shade (@dark_bg_color, 0.95)));
69+ border-width: 0;
70 }
71
72 PanelApplet .button {
73@@ -34,6 +47,7 @@
74 border-color: shade (@dark_bg_color, 0.9);
75 border-radius: 0;
76 border-width: 0 1px 0 1px;
77+ -GtkButton-inner-border: 2;
78
79 text-shadow: none;
80