light-themes

Merge lp:~mitya57/light-themes/panel-fixes-part-1 into lp:~ubuntu-art-pkg/light-themes/trunk

  1. panel-fixes-part-1
  2. Merge into trunk
Proposed by Dmitry Shachnev
Status: Merged
Merged at revision: 214
Proposed branch: lp:~mitya57/light-themes/panel-fixes-part-1
Merge into: lp:~ubuntu-art-pkg/light-themes/trunk
Diff against target: 79 lines (+29/-0)
2 files modified
Ambiance/gtk-3.0/apps/gnome-panel.css (+15/-0)
Radiance/gtk-3.0/apps/gnome-panel.css (+14/-0)
To merge this branch: bzr merge lp:~mitya57/light-themes/panel-fixes-part-1
Reviewer Review Type Date Requested Status
Andrea Cimitan Approve
Ubuntu Artwork Packagers Pending
Review via email: mp+95781@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Whoops, I specified wrong gradient for Ambiance separator, hope to fix this later tonight.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

OK to merge now, patch from bug 920832 needs merging together with this.

lp:~mitya57/light-themes/panel-fixes-part-1 updated
213. By Dmitry Shachnev

Fix low-contrast labels in window list (LP: #828392)

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Fixed the most annoying issue, now it should be perfect :)

Revision history for this message
Andrea Cimitan (cimi) wrote :

Tested with unity, seems to be working fine, merging

Revision history for this message
Andrea Cimitan (cimi) :
review: Approve
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

@Andrea: some unrelated questions:

- Why do we still carry gtk-2 theming for gnome apps? Can it be dropped?
- Why do we have most of the gnome-terminal theming commented out? Are there any plans to revert it?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Ambiance/gtk-3.0/apps/gnome-panel.css'
--- Ambiance/gtk-3.0/apps/gnome-panel.css 2012-02-08 12:55:19 +0000
+++ Ambiance/gtk-3.0/apps/gnome-panel.css 2012-03-06 15:14:22 +0000
@@ -10,6 +10,18 @@
10 color: @dark_fg_color;10 color: @dark_fg_color;
11}11}
1212
13PanelApplet {
14 border-width: 0;
15}
16
17PanelSeparator {
18 border-width: 0;
19 background-image: -gtk-gradient (linear, left top, left bottom,
20 from (shade (@dark_bg_color, 1.5)),
21 to (shade (@dark_bg_color, 1.05)));
22 color: @dark_fg_color;
23}
24
13.gnome-panel-menu-bar,25.gnome-panel-menu-bar,
14PanelApplet > GtkMenuBar.menubar,26PanelApplet > GtkMenuBar.menubar,
15PanelApplet > GtkMenuBar.menubar.menuitem,27PanelApplet > GtkMenuBar.menubar.menuitem,
@@ -25,15 +37,18 @@
25 background-image: -gtk-gradient (linear, left top, left bottom,37 background-image: -gtk-gradient (linear, left top, left bottom,
26 from (shade (@dark_bg_color, 1.5)),38 from (shade (@dark_bg_color, 1.5)),
27 to (shade (@dark_bg_color, 1.05)));39 to (shade (@dark_bg_color, 1.05)));
40 border-width: 0;
28}41}
2942
30PanelApplet .button {43PanelApplet .button {
31 background-image: -gtk-gradient (linear, left top, left bottom,44 background-image: -gtk-gradient (linear, left top, left bottom,
32 from (shade (@dark_bg_color, 1.5)),45 from (shade (@dark_bg_color, 1.5)),
33 to (shade (@dark_bg_color, 1.05)));46 to (shade (@dark_bg_color, 1.05)));
47 color: @dark_fg_color;
34 border-color: shade (@dark_bg_color, 0.78);48 border-color: shade (@dark_bg_color, 0.78);
35 border-radius: 0;49 border-radius: 0;
36 border-width: 0 1px 0 1px;50 border-width: 0 1px 0 1px;
51 -GtkButton-inner-border: 2;
3752
38 text-shadow: none;53 text-shadow: none;
3954
4055
=== modified file 'Radiance/gtk-3.0/apps/gnome-panel.css'
--- Radiance/gtk-3.0/apps/gnome-panel.css 2012-02-08 12:55:19 +0000
+++ Radiance/gtk-3.0/apps/gnome-panel.css 2012-03-06 15:14:22 +0000
@@ -10,6 +10,18 @@
10 color: @dark_fg_color;10 color: @dark_fg_color;
11}11}
1212
13PanelApplet {
14 border-width: 0;
15}
16
17PanelSeparator {
18 border-width: 0;
19 background-image: -gtk-gradient (linear, left top, left bottom,
20 from (shade (@dark_bg_color, 1.15)),
21 to (shade (@dark_bg_color, 0.95)));
22 color: @dark_fg_color;
23}
24
13.gnome-panel-menu-bar,25.gnome-panel-menu-bar,
14PanelApplet > GtkMenuBar.menubar,26PanelApplet > GtkMenuBar.menubar,
15PanelApplet > GtkMenuBar.menubar.menuitem,27PanelApplet > GtkMenuBar.menubar.menuitem,
@@ -25,6 +37,7 @@
25 background-image: -gtk-gradient (linear, left top, left bottom,37 background-image: -gtk-gradient (linear, left top, left bottom,
26 from (shade (@dark_bg_color, 1.15)),38 from (shade (@dark_bg_color, 1.15)),
27 to (shade (@dark_bg_color, 0.95)));39 to (shade (@dark_bg_color, 0.95)));
40 border-width: 0;
28}41}
2942
30PanelApplet .button {43PanelApplet .button {
@@ -34,6 +47,7 @@
34 border-color: shade (@dark_bg_color, 0.9);47 border-color: shade (@dark_bg_color, 0.9);
35 border-radius: 0;48 border-radius: 0;
36 border-width: 0 1px 0 1px;49 border-width: 0 1px 0 1px;
50 -GtkButton-inner-border: 2;
3751
38 text-shadow: none;52 text-shadow: none;
3953