GtkSalMenu: menu File>Templates>Manage executes action from the wrong submenu

Bug #1559135 reported by Björn Michaelsen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LibreOffice
Fix Released
Medium
libreoffice (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

If I build with Dbus then the menu File > Templates > Manage opens a toolbar instead of the Template manager. In LO 5.0 the toolbar is the Media Playback, in the master the toolbar is the Insert toolbar.
(more details see https://bugs.documentfoundation.org/show_bug.cgi?id=92067)

Revision history for this message
In , JBF (jbf-faure) wrote :

I build LibreOffice 5.0 branch (currently beta-3+) and master under Ubuntu 15.04 x86-64 and both have the same problem, directly linked to Unity. If I build with Dbus then the menu File > Templates > Manage opens a toolbar instead of the Template manager. In LO 5.0 the toolbar is the Media Playback, in the master the toolbar is the Insert toolbar.
If I add the option --disable-dbus in my autogen.input then the problem is gone (and the global menu in Unity too).

Best regards. JBF

Revision history for this message
In , JBF (jbf-faure) wrote :

Hi Bjoern,

This bug report may be interesting for you.

Best regards. JBF

Revision history for this message
In , Geraldg-k (geraldg-k) wrote :

I have installed the deb-64-packages. The template manager opens correctly.

Revision history for this message
In , JBF (jbf-faure) wrote :

To reproduce the problem, you need to use LibreOffice 5.0 rc3 with the vcl plugin gtk2 instead of gtk3 that is used by default. To do that set the environment variable SAL_USE_VCLPLUGIN to the value "gtk":
export SAL_USE_VCLPLUGIN="gtk"

The problem does not occur for me if I use the VCL plugin for GTK3.

Best regards. JBF

Revision history for this message
In , Adolfo Jayme Barrientos (fitojb) wrote :

Created attachment 118713
Screencast

I can confirm that clicking File > Template > Manage opens the Fontwork toolbar instead of the Template Manager. Its shortcut works, nevertheless. See the attached screencast.

Revision history for this message
In , Momonasmon (momonasmon) wrote :

*** Bug 98377 has been marked as a duplicate of this bug. ***

Revision history for this message
In , Momonasmon (momonasmon) wrote :

That

Revision history for this message
In , JBF (jbf-faure) wrote :

It seems that the workaround consisting in using the GTK3 plugin does not work for the current master and LO 5.1

Best regards. JBF

Revision history for this message
In , Caolanm (caolanm) wrote :

Hillarious with native gtk3 menus I get a drawing shape with this menu. I think the problem is that the command ".uno:NewDoc" is duplicated in the menu structure causing "odd things" to happen with the second .uno:NewDoc

Revision history for this message
In , Libreoffice-commits (libreoffice-commits) wrote :

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e22618a355c0e506b8cfac9c52e9564db26949d2

Resolves: tdf#92067 with duplicate menu entries track which to activate

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Revision history for this message
In , Caolanm (caolanm) wrote :

That seems to work fine for this duplicated entry.

caolan->cor: I seem to recall you showing me a problem with this exact menu entry in the past.

Revision history for this message
In , Libreoffice-commits (libreoffice-commits) wrote :

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9b729dba5d1dd9a87241284a67ee4dfc91bee2f&h=libreoffice-5-1

Resolves: tdf#92067 with duplicate menu entries track which to activate

It will be available in 5.1.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Revision history for this message
In , JBF (jbf-faure) wrote :

Verified fixed in LO 5.1.2.0.0+.
Thank you very much.

Best regards. JBF

description: updated
tags: added: block-proposed
Changed in df-libreoffice:
importance: Unknown → Medium
status: Unknown → Fix Released
Revision history for this message
Björn Michaelsen (bjoern-michaelsen) wrote :

smoketested build, verified bugfix, autopkgtests look ok => removing block-proposed

tags: removed: block-proposed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libreoffice - 1:5.1.1-0ubuntu1

---------------
libreoffice (1:5.1.1-0ubuntu1) xenial; urgency=medium

  * upstream released an rc3 = final
  * allow libreoffice-style-elementary as alternative for -breeze in libreoffice-gtk (LP: #1483914)
  * fix File>Templates>Manage executes wrong action in unity (LP: #1559135)

 -- Bjoern Michaelsen <email address hidden> Fri, 18 Mar 2016 15:19:35 +0100

Changed in libreoffice (Ubuntu):
status: New → Fix Released
Revision history for this message
In , Adolfo Jayme Barrientos (fitojb) wrote :

*** Bug 99154 has been marked as a duplicate of this bug. ***

Revision history for this message
In , Samuel-mehrbrodt (samuel-mehrbrodt) wrote :

This bug still happens for me in master built on 2016-04-15.

Revision history for this message
In , Momonasmon (momonasmon) wrote :

(In reply to Samuel Mehrbrodt (CIB) from comment #14)
> This bug still happens for me in master built on 2016-04-15.

It was broken again with

commit 66db55aa84e8401a9eccedb02c67150833a344ba
Author: Caolán McNamara <email address hidden>
Date: Tue Mar 15 11:15:40 2016 +0000

    Resolves: tdf#98636

Changed in df-libreoffice:
status: Fix Released → Confirmed
Revision history for this message
In , Libreoffice-commits (libreoffice-commits) wrote :

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=27014f563577c3c5da19e37a57d4e73c0ebae140

Resolves: tdf#92067 and tdf#99599, use a foolproof action naming scheme

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Changed in df-libreoffice:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.