doesn't check exit code from install.py

Bug #269035 reported by Colin Watson
2
Affects Status Importance Assigned to Milestone
usb-creator (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: usb-creator

It's possible for install.py to exit non-zero, but for usb-creator to complete successfully anyway; see bug 269032 for a scenario where this happens at the moment. usb-creator should check the exit code and handle it properly (i.e. do more than just log it).

Evan (ev)
Changed in usb-creator:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-creator - 0.1.3

---------------
usb-creator (0.1.3) intrepid; urgency=low

  [ Evan Dandrea ]
  * Added a man page for usb-creator.8.
  * UI reworking after discussions with mpt. Thanks Matthew.
    - The labels are far less wordy.
    - Enabling persistence is now an explict option button selection rather
      than implicitly enabled when the slider is moved to a value greater
      than 0.
    - There are now two treeviews, instead of the previous comboboxes, that
      update automatically to reflect changes to the device's structure, and
      provide warnings when a device is either unusable or require the user
      to delete some files to free up space before continuing.
  * Fixed the left-alignment of labels thanks to a tip from Colin Watson.
  * Merged the separate CD and ISO lists into the CD list in the backend.
  * Replaced the log-output backed command wrapper with a simpler solution
    (LP: #269044).
  * Now logging to ~/.usb-creator.log instead of just stdout.
  * Moved the persistence code from the backend to scripts/install.py and
    wired up the persistence scale in the frontend.
  * The backend now reports the task description in addition to the progress
    value.
  * A failure dialog is now shown when scripts/install.py exits non-zero
    (LP: #269035).
  * Mount the target device at install time if it has not already been
    mounted (LP: #269032).
  * Properly set the labels of the progress dialog on install startup.
  * Do not make the dialogs modal.
  * Elevate privileges using gksu.
  * Added a .desktop file (LP: #267788).
  * Work around a bug in syslinux wherein it can only find the configuration
    file for the option labels in the root of the device.
  * Handle devices with empty partition tables.
  * Automatically mount (and unmount) partitions (LP: #269032).
  * Fixed missing Debian dependencies (LP: #269767).
  * UI Freeze exception upload (LP: #270530).

  [ Colin Watson ]
  * Avoid executing commands via the shell (LP: #269048).

 -- Evan Dandrea <email address hidden> Tue, 16 Sep 2008 03:29:55 -0400

Changed in usb-creator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.