Change quit icon to use power icon from the desktop

Bug #354003 reported by Rick Spencer
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Netbook Remix Launcher
Won't Fix
Undecided
Unassigned
netbook-launcher (Ubuntu)
Fix Released
High
Unassigned
Jaunty
Fix Released
High
Registry Administrators

Bug Description

The Launcher in UNR features a "quit" button. This button has an icon of a door with an arrow. This icon should not be used, but rather the Ubuntu power icon should be.

Tags: ubuntu-unr
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :
Changed in mobile-meta (Ubuntu):
assignee: nobody → rick-rickspencer3
importance: Undecided → High
milestone: none → ubuntu-9.04
status: New → Confirmed
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

This is a request from sabdfl. We should assess the impact of this change before making it. Impact includes:
 - development effort
 - schedule risk
 - regression risk
 - doc churn
 - marketing churn

Subscribed release team in case exceptions are necessary.

Martin Pitt (pitti)
Changed in mobile-meta (Ubuntu):
assignee: rick-rickspencer3 → canonical-mobile
Revision history for this message
Martin Pitt (pitti) wrote :

Assigned to mobile team, to get their input, and because they'll do the update.

  - development effort

The icon you want to have is /usr/share/icons/gnome/scalable/actions/system-shutdown.svg, shipped in gnome-icon-theme. If UNR ships gnome-icon-theme, then just patch your panel to use this icon name (shoudl be an one-line change). If you don't ship gnome-icon-theme, then copy that icon to your panel package, perhaps rename it, and use that icon name.

So in either case, the development effort is very small, something like half an hour.

  - schedule risk
  - regression risk

Replacing an icon name is not an intrusive code-wise, so I am not concerned about this, with my release hat on. Please do get this change in before the final freeze next Thursday, though, to avoid rebuilding images just for this.

  - doc churn

Does not impact Ubuntu desktop, but possibly existing screenshots in UNR documentation. I'll subscribe the documentation team, and also drop a mail to their ML to warn them about this issue.

  - marketing churn

Out of my area of expertise, but I expect this to be very low.

Revision history for this message
Loïc Minier (lool) wrote :

I think it's a change in netbook-launcher:
src/launcher-sidebar.c:1147:
  shortcut = launcher_shortcut_new ("gtk-quit",
                                    _("Quit..."),
                                    FALSE);

affects: mobile-meta (Ubuntu) → netbook-launcher (Ubuntu)
Revision history for this message
Loïc Minier (lool) wrote :

I believe the correct icon is:
#define PANEL_ICON_LOGOUT "system-log-out"

Revision history for this message
Dean Sas (dsas) wrote :

The doc team don't yet have any UNR specific documentation.

Revision history for this message
Martin Pitt (pitti) wrote :

Loic,

no, system-log-out is the running stylized green man in gnome-icon-theme, and the _red_ power button in human icon theme. In comment 2, Rick attached an icon which is gnome-icon-theme's system-shutdown.

Revision history for this message
Neil J. Patel (njpatel) wrote :

When Mark notified me of this bug, he mentioned replacing the current icon with the red quit icon from the human theme. I am just confirming with him which icon should be used.

The correct place to change it is in Loic's first comment, launcher_shortcut_new ("gtk-quit", foo, bar) would need to be changed. Once we know the correct icon, do you want me to roll a new netbook-launcher release, or will it be patched in the packaging?

Revision history for this message
Matthew East (mdke) wrote :

(unsubscribed ubuntu-doc from this as per comment 7)

Revision history for this message
Loïc Minier (lool) wrote :

Martin, note that I didn't mean the running man but the red power button; that is:
/usr/share/icons/Human/24x24/actions/system-log-out.png
(BTW this file is broken: /usr/share/icons/Human/scalable/actions/system-log-out.png)

I don't mind either icon: neither of them matches the available options in the desktop anyway; I just thought the red power button was more in the same colors as UNR and was more Ubuntu ish as it's more visibleon the desktop.

For the icon which Rick mentionned, the correct name is "system-shutdown".

Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

Yes, I confirm /usr/share/icons/Human/24x24/actions/system-log-out.png is the one I meant (red and white power button).

Thanks,
Mark

Revision history for this message
Neil J. Patel (njpatel) wrote :

I've rolled a new release with the icon name change: https://edge.launchpad.net/netbook-remix-launcher/+download (1.6.19).

Steve K. is currently dealing with updating Jaunty to the previous release (1.6.18), which contained some very important translation fixes, so updating Jaunty to this release of netbook-launcher would take care of that too.

Revision history for this message
Dougie Richardson (dougierichardson) wrote :

Actually we do have UNR documentation (Bug #340246), I've been working on it for a couple of weeks but the branch is on my account until I've found a way to integrate it with the current ubuntu-doc package.

As the docs are at a very early stage and we use description rather than images, this is easily rectified from out perspective.

Matt Zimmerman (mdz)
Changed in netbook-launcher (Ubuntu Jaunty):
status: Confirmed → Triaged
Revision history for this message
David Mandala (davidm) wrote : Re: [Bug 354003] Re: Change quit icon to use power icon from the desktop

Neil J. Patel wrote:
> When Mark notified me of this bug, he mentioned replacing the current
> icon with the red quit icon from the human theme. I am just confirming
> with him which icon should be used.
>
> The correct place to change it is in Loic's first comment,
> launcher_shortcut_new ("gtk-quit", foo, bar) would need to be changed.
> Once we know the correct icon, do you want me to roll a new netbook-
> launcher release, or will it be patched in the packaging?
>
Yes please

--
David Mandala <davidm at canonical dot com>
http://www.canonical.com/ Public Key id: 45B2D952
Murphy TX, 75094 +1.214.774.2569 O +1.972.693.4007 C

Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

attached actual correct icon, just because I'm paranoid

Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

Sounds like a go from marketing.

Message from Gerry Carr:

<snip />

We more slowly change printed docs and where it is featured, if at all,
will change on next rev.

<snip />

we will try and feature or will quickly replace the 'wrong' icon when we
can.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package netbook-launcher - 1.6.19-0ubuntu1

---------------
netbook-launcher (1.6.19-0ubuntu1) jaunty; urgency=low

  * New upstream release.
    - Changes Quit icon. (LP: #354003)

 -- Steve Kowalik <email address hidden> Sat, 04 Apr 2009 14:06:30 +1100

Changed in netbook-launcher (Ubuntu Jaunty):
status: Triaged → Fix Released
Revision history for this message
Paul Larson (pwlars) wrote :

This bug has been moved to Ubuntu distribution

tags: added: ubuntu-unr
Changed in netbook-remix-launcher:
status: New → Won't Fix
Curtis Hovey (sinzui)
Changed in netbook-launcher (Ubuntu):
assignee: Registry Administrators (registry) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.