Ubuntu
sl-modem package

ALSA modem detection in init script broken in non-English locales [sync sl-modem]

Bug #626231 reported by Milan Bouchet-Valat
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
sl-modem (Debian)
Fix Released
Unknown
sl-modem (Ubuntu)
Fix Released
High
Unassigned
Lucid
Won't Fix
Undecided
Unassigned

Bug Description

The /etc/init.d/sl-modem-daemon script checks for the presence of modems by parsing the output of 'aplay -l'. But it's looking for English strings, and they can be localized - in particular, the word "card" changes, e.g.:
- English: card 0: ICH6 [Intel ICH6], device 0: Intel ICH [Intel ICH6]
- French: carte 0: ICH6 [Intel ICH6], périphérique 0 : Intel ICH [Intel ICH6]

So the best solution is to set LC_ALL=C before all calls to 'aplay'. Patch follows.

For reference, people with amd64 versions get the following error, since the ALSA modem is not detected:
> Only access through ALSA is available on amd64 but slamr driver was chosen!
> Make sure that an ALSA driver for your chipset is available and is loaded
> and that access to SmartLink modem components is supported by it.

People with 32bit systems are likely to be told to build the slamr module, which is not needed.

Revision history for this message
Milan Bouchet-Valat (nalimilan) wrote :

Rationale for SRU: the package is completely broken in its current state for all locales with translated aplay output. Users with such modems won't be able to use them at all. With the simple fix (tested locally), the driver can be installed with Jockey very easily.

Of course, 56k modems are not that essential today, but the risk of SRUing only affects users with such modems, so it's definitely worth it.

Changed in sl-modem (Ubuntu):
importance: Undecided → High
status: New → Triaged
Revision history for this message
Milan Bouchet-Valat (nalimilan) wrote :

The fix has just been applied to the Debian package, so for Maverick a simple sync should be enough. For Lucid, a direct SRU would still be needed since other changes have been introduced between Lucid and Maverick packages.

Revision history for this message
Martin Pitt (pitti) wrote :

Subscribed ubuntu-archive for the sync. We are currently in beta freeze, so I can't do it right now.

summary: - ALSA modem detection in init script broken in non-English locales
+ ALSA modem detection in init script broken in non-English locales [sync
+ sl-modem]
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sl-modem - 2.9.11~20100718-2

---------------
sl-modem (2.9.11~20100718-2) unstable; urgency=low

  * debian/sl-modem-daemon.init: Run 'aplay -l' with LC_ALL=C to fix modem
    detection with non-English locales (Closes: #626231) (LP: #626231), patch
    submitted by: Milan Bouchet-Valat <email address hidden>
  * debian/control: Bumped Standards-Version to 3.9.1, no changes needed.

sl-modem (2.9.11~20100718-1) unstable; urgency=low

  * New upstream release.
  * debian/watch: Fixed mangling to get a proper orig tarball
  * Removed 2.6.33.diff patch as it got applied upstream.
  * debian/copyright: Replaced empty lines in license text with ' .'
 -- ???? ???????? (Ahmed El-Mahmoudy) <email address hidden> Mon, 06 Sep 2010 11:28:12 +0100

Changed in sl-modem (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote :

Unsubscribing ubuntu-archive; the remaining task is an SRU, which we can't take action on right now.

Bug Watch Updater (bug-watch-updater)
Changed in sl-modem (Debian):
status: Unknown → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in sl-modem (Ubuntu Lucid):
status: New → Confirmed
Revision history for this message
Rolf Leggewie (r0lf) wrote :

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".

Changed in sl-modem (Ubuntu Lucid):
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.