Ubuntu
xfce4-indicator-plugin package

doesn't support vertical panel layout

Bug #787977 reported by Simon Steinbeiß on 2011-05-25

This bug affects 1 person

	Status	Importance	Assigned to
xfce4	Unknown	Unknown	xfce-bugs #7564
xfce4-indicator-plugin (Ubuntu)	Fix Released	Undecided	Unassigned
Natty	Fix Released	Undecided	Unassigned

Bug Description

Binary package hint: xfce4-indicator-plugin

when using a vertical panel layout, the indicators don't change orientation, meaning they stay horizontally lined up. this results in only the first one or two indicators to be shown, depending on the vertical panel's width.

expected behaviour: the indicators should change orientation and line up on top of each other rather than next to each other.

1. impact: users cannot use the indicators/indicator-plugin in vertical panels because the orientation doesn't change with the current version.
2. bug addressed: in these two commits (http://git.xfce.org/panel-plugins/xfce4-indicator-plugin/commit/?id=4e55a3d7292bd4f15b1555530f58e559cb99e965 and http://git.xfce.org/panel-plugins/xfce4-indicator-plugin/commit/?id=2c0cc99c948d1b5e1ff5fb11057a6bb549849a2d) the bug was addressed and fixed. (the diff is quite minimal)
3. patch:
4. TEST CASE: change the default xubuntu panel's orientation to vertical (or change any panel containing the indicator-plugin and using more than two indicators with it) and voilá: you'll only see the first one or two indicators (depending on width of vertical panel). the others are cropped/hidden.
5: regression potential:

See original description

Tags:

Related branches

lp:ubuntu/oneiric/xfce4-indicator-plugin

lp:ubuntu/natty-proposed/xfce4-indicator-plugin

Revision history for this message

Simon Steinbeiß (ochosi) wrote on 2011-05-25:

a fix is already in git master according to mark trompell (dev of the plugin).
this should really land in natty!

Revision history for this message

Charlie Kravetz (cjkgeek) wrote on 2011-05-25:

After this is synced to Oneiric Ocelot, the latest development version of Xubuntu, it can have a SRU submitted against it to have to put into Natty. If you need a fix for the bug in previous versions of Ubuntu, please do steps 1 and 2 of the SRU Procedure [1] to bring the need to a developer's attention.

[1]: https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

Simon Steinbeiß (ochosi) on 2011-05-25

description:

updated

Revision history for this message

Stéphane Graber (stgraber) wrote on 2011-05-25:

Debdiff for Oneiric Edit (4.0 KiB, text/plain)

I quickly made a debdiff out of the two upstream commits (attached).
A test package is available at: http://www.stgraber.org/download/xfce4-indicator-plugin_0.2.0-0ubuntu5_amd64.deb

I'll now upload it to Oneiric and to natty-proposed.

Changed in xfce4-indicator-plugin (Ubuntu Natty):
status:	New → Fix Committed

Revision history for this message

Stéphane Graber (stgraber) wrote on 2011-05-25:

Uploaded to natty-proposed. The SRU team should soon contact you to confirm that the fix works before it gets copied to -updates.

Package should also appear in Oneiric in a few minutes.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-05-25:

This bug was fixed in the package xfce4-indicator-plugin - 0.2.0-0ubuntu5

---------------
xfce4-indicator-plugin (0.2.0-0ubuntu5) oneiric; urgency=low

  * debian/patches:
    - 0004-cherry-pick-vertical-panel-fixes.patch: cherry-pick from upstreamt
      4e55a3d7292bd4f15b1555530f58e559cb99e965
      2c0cc99c948d1b5e1ff5fb11057a6bb549849a2d
      Fixes vertical panel issue with indicators (LP: #787977)
-- Stephane Graber <email address hidden> Wed, 25 May 2011 13:27:24 -0400

Changed in xfce4-indicator-plugin (Ubuntu):
status:	New → Fix Released

Revision history for this message

Simon Steinbeiß (ochosi) wrote on 2011-05-25:

vertical indicators screenshot Edit (46.0 KiB, image/png)

i tested a package built for natty 64bit, see the attached screenshot for reference.

Revision history for this message

Martin Pitt (pitti) wrote on 2011-05-30: Please test proposed package

Accepted xfce4-indicator-plugin into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags:

added: verification-needed

Revision history for this message

Simon Steinbeiß (ochosi) wrote on 2011-05-30:

Hey Martin,
I enabled and updated the xfce4-indicator-plugin package on two different systems to verify that it works, so yes, i can confirm that this fixes the bug.
Thanks!

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2011-05-30:

Thanks for testing Simon. Marking as verification-done

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-06-06:

#10

This bug was fixed in the package xfce4-indicator-plugin - 0.2.0-0ubuntu4.1

---------------
xfce4-indicator-plugin (0.2.0-0ubuntu4.1) natty-proposed; urgency=low