lp:~jamesodhunt/upstart/bug-1357252
- Get this branch:
- bzr branch lp:~jamesodhunt/upstart/bug-1357252
Branch merges
- Stéphane Graber (community): Approve
-
Diff: 503 lines (+287/-55)8 files modifiedChangeLog (+21/-0)
init/cgroup.c (+56/-53)
init/cgroup.h (+2/-0)
init/job.c (+30/-0)
init/job.h (+7/-0)
init/job_process.c (+15/-1)
init/job_process.h (+2/-1)
init/tests/test_job.c (+154/-0)
Related bugs
Bug #1357252: upstart can race with cgmanager when using remove-on-empty | Undecided | Fix Released |
Related blueprints
Branch information
Recent revisions
- 1661. By James Hunt
-
* init/cgroup.c:
- Removed nih_debug() and nih_warn() calls since, although
useful, this output pollutes job logs when running in debug mode.
- cgroup_clear(): New function to request cgroups be removed.
- cgroup_create(): Don't mark cgroups 'remove-on-empty' since Upstart
can race with cgmanager.
* init/job.c: job_last_process(): New helper function.
* init/job_process.c:
- job_process_spawn_with_ fd(): Request that the
cgroup manager destroy all job cgroups after upstart has created
required cgroups for last job process which avoids the
'remove-on-empty' race (LP: #1357252).
- job_process_error_handler( ): Added handling for new
JOB_PROCESS_ ERROR_CGROUP_ CLEAR error.
* init/job_process.h: JobProcessErrorType: Added new
JOB_PROCESS_ERROR_CGROUP_ CLEAR error.
* init/tests/test_job. c: test_job_ last_process( ): New test for
job_last_process( ).
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:upstart