merge OVSInterfaceDriver and OVSVethInterfaceDriver

Bug #1049385 reported by dan wendlandt
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Akihiro Motoki

Bug Description

Due to some issues using OVS internal interfaces across namespaces with openflow controllers, a patch introduced the OVSVethInterfaceDriver in addition to the base OVSInterfaceDriver.

We would prefer to have a single OVS interface driver used to avoid confusion and duplication, but decided not to do this immediately as the issue was found the day of Folsom RC1. We should immediately work on merging the two, and will plan on taking this change in an RC2, assuming we need an RC2 for other reasons.

dan wendlandt (danwent)
Changed in quantum:
importance: Undecided → High
assignee: nobody → Akihiro Motoki (amotoki)
status: New → Confirmed
Revision history for this message
Gary Kotton (garyk) wrote :

How does the hybrid driver fit into the picture?

Revision history for this message
Akihiro Motoki (amotoki) wrote :

Hi Gary,
I have not understood what you mean with "hybrid driver". Could you explain more detail?

Perhaps "hybrid driver" you mentioned is a hybrid driver in nova VIF driver, but I don't think such a complicated way is not needed in this case. The original reason that OVSVethInterfaceDriver was (temporarily) introduced is Bug #1048681.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14323

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/14323
Committed: http://github.com/openstack/quantum/commit/95c4d0e82f92fdf6d2a4e93453df3b831193f54a
Submitter: Jenkins
Branch: master

commit 95c4d0e82f92fdf6d2a4e93453df3b831193f54a
Author: Akihiro MOTOKI <email address hidden>
Date: Fri Sep 28 22:05:50 2012 +0900

    Merge OVSVethInterfaceDriver into OVSInterfaceDriver

    Fixes bug 1049385

    Due to some issues using OVS internal interfaces across namespaces
    with OpenFlow controllers (bug 1048681), a patch introduced the
    OVSVethInterfaceDriver in addition to the base OVSInterfaceDriver.
    However, OVSVethInterfaceDriver is just a variation of OVSInterfaceDriver
    and the difference is how to create an interface (OVS internal vs veth).
    This patch merge OVSVethInterfaceDriver into OVSInterfaceDriver
    by introducing a new flag 'ovs_use_veth' (which defaults to False).

    Change-Id: Ie8b01e6776bf703f72a9e2a471b24e126f6e2322

Changed in quantum:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in quantum:
milestone: none → grizzly-1
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.