improvements to API validation logic

Does HTTP 400 make sense for this test?

quantum/quantum/tests/unit/test_db_plugin.py, line 602:
    def test_update_invalid_json_400(self):
        with self.network() as net:
            req = self.new_update_request('networks',
                                          '{{"name": "aaa"}}',
                                          net['network']['id'])
            res = req.get_response(self.api)
            self.assertEqual(res.status_int, 400)

Answering my own question:
Yes BadRequest does make sense because the data '{{"name": "aaa"}}' is the wrong type/format for the 'networks' resource.

This bug is marked in progress, but we're lacking a link to a gerrit patchset; I did a little search on gerrit but could not find any.

Henry, can you point me to the correct review? (or fix the commit message there so launchpad is automatically updated)

Sorry, being new to this process I mis-interpreted the meaning of "in progress".
I am working on it but not yet ready to send out changes for review.
What should the status be set to?

Hi Henry,

"In Progress" without a patch on gerrit is a valid status.
On the other hand, OpenStack gerrit automatically updates the status of Launchpad bug when the patch is uploaded for revierw. Thus a patch is available on gerrit in most cases. This is what Salvatore says.
If you set the status to "In Progress", please keep your status up-to-date. It is helpful.

Now the limit of G-3 development milestone is coming and we quantum-core needs to trace the status of each bug.

Thanks,

No worries. I'll keep it target for G-3 (but being a low priority bug it might be untargeted again - especially if the code is pushed close to the deadline)

Fix proposed to branch: master
Review: https://review.openstack.org/21460

Reviewed: https://review.openstack.org/21460
Committed: http://github.com/openstack/quantum/commit/be77455856fcc88300b0ad5a36211ebd37f0e453
Submitter: Jenkins
Branch: master

commit be77455856fcc88300b0ad5a36211ebd37f0e453
Author: Henry Gessau <email address hidden>
Date: Thu Feb 7 16:01:28 2013 -0500

    Improvements to API validation logic.

    Do not automatically map generic exceptions like AttributeError to
    http errors (instead they should be handled closer to where they occur
    so that they can be "intelligently" converted to the appropriate
    error).

    Fix up some expected error codes in the unit tests.
    Improve some of the validation messages.
    Remove all use of locals() in attributes.py

    Fixes: bug #1076813
    Change-Id: Iabf8808a840e927307bbcae4cd41790af3d79a9e