widelands

Increasing resolution in fullscreen results in the right and bottom sides not being updated properly

Bug #1203006 reported by Hans Joachim Desserud
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned
widelands build19-rc1

Bug Description

I was clicking around, verifying bug 1159968 / bug 1130905 / bug 1137765 was gone, when I noticed this odd behavior:

1. Go to options and switch to fullscreen with a small resolution (for instance 800x600).
2. In fullscreen, go back to options and switch to a larger resolution (for instance 1024x768).

Expected result:
The whole window is now rendered according to the new resolution.

Actual result:
While the content scales up to fit the new resolution, parts of the right and bottom side are not rendered. If you are lucky enough to hit the buttons in those areas, they are in fact there, they're just not being drawn. Looks like it simply keeps rendering according to the smaller resolution, not bothering with the additional content.

(To escape, go to options, select a lower resolution again and move the cursor down while clicking, hoping to hit the Ok button to change it back.)

At first I feared this was another regression, but I was able to reproduce it on build17 as well, so it's apparently been here for a while. If someone has a fix for this in by build18, that would be nice but feel free to reassign.

Widelands r6638 on Ubuntu 13.04.

Tags: ui

Related branches

lp:~widelands-dev/widelands/fix_some_resizing_bugs
Tino: Approve
Diff: 644 lines (+154/-171)
13 files modified
src/editor/editorinteractive.cc (+1/-1)
src/graphic/graphic.cc (+79/-73)
src/graphic/graphic.h (+26/-11)
src/graphic/text/test/render_richtext.cc (+1/-2)
src/logic/map_info.cc (+1/-2)
src/logic/ware_descr.cc (+1/-1)
src/notifications/note_ids.h (+2/-0)
src/wlapplication.cc (+18/-60)
src/wlapplication.h (+1/-6)
src/wui/interactive_base.cc (+14/-10)
src/wui/interactive_base.h (+8/-3)
src/wui/interactive_player.cc (+1/-1)
src/wui/interactive_spectator.cc (+1/-1)
Revision history for this message
Shevonar (shevonar) wrote :

In my opinion this should be fixed by using the correct native display resolution in fullscreen mode and disable the resolution list when fullscreen is enabled.

Revision history for this message
SirVer (sirver) wrote :

I do not share this opinion - I think it is nice to see the graphics bigger in fullscreen, so I'd much prefer to still have other resolutions available. Can you think of a way to hint the user at the default resolution, so that they will pick it with a higher probability?

Changed in widelands:
status: New → Confirmed
Revision history for this message
Shevonar (shevonar) wrote :

How about selecting the default resolution but not disabling the list. That is not very nice as resolution will change when you uncheck the fullscreen checkbox and check it again, but it will maybe do the trick. Of course it would be a lot nicer to have a scalable UI but that is currently not possible and there are some other bug reports about that topic I guess.

Revision history for this message
SirVer (sirver) wrote :

Scalable UI is a lot of work - just redoing all the menus would be a big pain :).

We could also offer a "prefer native resolution" checkbox which is selected when fullscreen is enabled. We would then empty the list of resolutions up to only the one. This is less interruption to the user at the cost of one more (possibly confusing) UI element. I took the idea from apple - they do that in their resolution settings.

SirVer (sirver)
Changed in widelands:
milestone: build18-rc1 → none
Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Still reproducible in r7119.

Changed in widelands:
status: Incomplete → Confirmed
Revision history for this message
SirVer (sirver) wrote :

I changed my mind and now agree with #1 :). The reason is that I think we might be able to implement zooming now with the software renderer gone.

Changed in widelands:
status: Confirmed → In Progress
Revision history for this message
SirVer (sirver) wrote :

Fixed in r7277. You can no longer change the fullscreen resolution.

Changed in widelands:
status: In Progress → Fix Committed
milestone: none → build19-rc1
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.