[SRU] gnash: youtube play with ffmpeg media handler broken on wheezy

Bug #1253468 reported by Dimitri John Ledkov
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnash (Debian)
Fix Released
Unknown
gnash (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Low
Unassigned
Quantal
Won't Fix
Low
Unassigned
Raring
Won't Fix
Low
Unassigned
Saucy
Fix Released
Low
Unassigned
Trusty
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

This bug is in the built-in ffmpeg media handler that comes with gnash. This bug affects the ffmpeg handler in such a way that it does not work when trying to play videos. Upstream and Debian have attributed this to deprecated api.

Uploading the attached debdiffs, which include an upstream patch to fix this, should resolve this issue.

[Test Case]

As detailed in the original Debian bug (see the "Original Bug Description" section), the bug as-is now can be replicated by running gnash with a youtube link, where you can expect the circle to keep spinning and the video to not start:

$ gnash http://www.youtube.com/v/9sJUDx7iEJw?version=2

Upon application of this patch, you should be able to run the same command, then the video will play correctly.

[Regression Potential]

While this has not been extensively checked, there should be no regression potential from this patch, which primarily adds ifdefs in order to allow compatibility with older versions of the software.

[Original Bug Description]

Imported from Debian bug http://bugs.debian.org/729995:

Package: gnash
Version: 0.8.11~git20120629-1
Tags: wheezy patch
Severity: important

Gnash is built with two media handlers: ffmpeg and gstreamer.
Default is ffmpeg (libav) which is broken in wheezy due to deprecated api.

Biggest impact is youtube video play: circle keeps spinning, movie
doesn't start.

To reproduce:
$ gnash http://www.youtube.com/v/9sJUDx7iEJw?version=2

It can be workarounded by switching to gstreamer media handler:
$ echo "set mediahandler gst" >> ~/.gnashrc
    or
$ gnash -M gst http://www.youtube.com/v/9sJUDx7iEJw?version=2

Backporting following upstream change fixes that:

http://git.savannah.gnu.org/gitweb/?p=gnash.git;a=commitdiff;h=4b3dae970549d42723c2528c250a1f95248145c7

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Also proposed update bug report in debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=729998

Changed in gnash (Ubuntu Trusty):
status: New → Fix Released
Changed in gnash (Ubuntu Raring):
status: New → Triaged
Changed in gnash (Ubuntu Quantal):
status: New → Triaged
Changed in gnash (Ubuntu Saucy):
status: New → Triaged
Changed in gnash (Ubuntu Quantal):
importance: Undecided → Low
Changed in gnash (Ubuntu Raring):
importance: Undecided → Low
Changed in gnash (Ubuntu Quantal):
assignee: nobody → Dmitrijs Ledkovs (xnox)
Changed in gnash (Ubuntu Saucy):
importance: Undecided → Low
assignee: nobody → Dmitrijs Ledkovs (xnox)
Changed in gnash (Ubuntu Raring):
assignee: nobody → Dmitrijs Ledkovs (xnox)
Changed in gnash (Debian):
importance: Undecided → Unknown
Revision history for this message
Gabriele Giacone (ggzero) wrote :

Patch has just been accepted by release team and uploaded to stable.

https://release.debian.org/proposed-updates/stable_diffs/gnash_0.8.11~git20120629-1+deb7u1.debdiff

Any progress in backporting it?

Revision history for this message
Gabriele Giacone (ggzero) wrote :

Ehm no, last patch has been adapted to wheezy libav{codec,util,format} versions by removing ifdefs.
Correct one from upstream was already pointed in bug description.

Revision history for this message
Thomas Ward (teward) wrote :

Confirmed that this affects Precise, too. The workaround proposed here does work, however. (I'm nominating this for Precise because I confirmed it exists there)

Changed in gnash (Debian):
status: New → Fix Released
Revision history for this message
Gabriele Giacone (ggzero) wrote :

Rebuilt on precise with patch in comment #2, it does fix it.

Thomas Ward (teward)
Changed in gnash (Ubuntu Quantal):
assignee: Dimitri John Ledkov (xnox) → Thomas Ward (teward)
status: Triaged → In Progress
Changed in gnash (Ubuntu Raring):
assignee: Dimitri John Ledkov (xnox) → Thomas Ward (teward)
Changed in gnash (Ubuntu Saucy):
assignee: Dimitri John Ledkov (xnox) → Thomas Ward (teward)
Changed in gnash (Ubuntu Raring):
status: Triaged → In Progress
Changed in gnash (Ubuntu Saucy):
status: Triaged → In Progress
Changed in gnash (Ubuntu Precise):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Thomas Ward (teward)
Revision history for this message
Thomas Ward (teward) wrote :
description: updated
Revision history for this message
Thomas Ward (teward) wrote :
Revision history for this message
Thomas Ward (teward) wrote :
Revision history for this message
Thomas Ward (teward) wrote :
Changed in gnash (Ubuntu Precise):
status: In Progress → Triaged
Changed in gnash (Ubuntu Quantal):
status: In Progress → Triaged
Changed in gnash (Ubuntu Raring):
status: In Progress → Triaged
Changed in gnash (Ubuntu Saucy):
status: In Progress → Triaged
Changed in gnash (Ubuntu Quantal):
assignee: Thomas Ward (teward) → nobody
Changed in gnash (Ubuntu Raring):
assignee: Thomas Ward (teward) → nobody
Changed in gnash (Ubuntu Saucy):
assignee: Thomas Ward (teward) → nobody
Changed in gnash (Ubuntu Precise):
assignee: Thomas Ward (teward) → nobody
Revision history for this message
Thomas Ward (teward) wrote :

The attached debdiffs contain fixes for the specific releases of Ubuntu affected: Precise, Quantal, Raring, and Saucy.

Each of these has been build-tested in an `sbuild` chroot, and builds successfully.

summary: - gnash: youtube play with ffmpeg media handler broken on wheezy
+ [SRU] gnash: youtube play with ffmpeg media handler broken on wheezy
Changed in gnash (Ubuntu Saucy):
status: Triaged → In Progress
Changed in gnash (Ubuntu Raring):
status: Triaged → In Progress
Changed in gnash (Ubuntu Quantal):
status: Triaged → In Progress
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

All uploaded into unapproved queues, pending approval by sru team.
unsubscribed sponsors team.

Changed in gnash (Ubuntu Precise):
status: Triaged → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dimitri, or anyone else affected,

Accepted gnash into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnash/0.8.11~git20120629-1ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnash (Ubuntu Raring):
status: In Progress → Won't Fix
Changed in gnash (Ubuntu Saucy):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in gnash (Ubuntu Quantal):
status: In Progress → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Dimitri, or anyone else affected,

Accepted gnash into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnash/0.8.11~git20120629-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnash (Ubuntu Precise):
status: In Progress → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Dimitri, or anyone else affected,

Accepted gnash into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnash/0.8.10-5ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Thomas Ward (teward) wrote :

Brian, or anyone else on the SRU team:

I tested the version in precise-proposed, and the version there does indeed fix this issue.

I'm not certain how to change the tags, since this SRU is multi-release targeted, so I'm leaving the tags alone, until someone can give adequate guidance for this.

Thomas Ward (teward)
tags: added: verification-done-precise
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnash - 0.8.10-5ubuntu1.1

---------------
gnash (0.8.10-5ubuntu1.1) precise-proposed; urgency=low

  * New upstream patch:
    + debian/patches/fix-ffmpeg-media-handler.patch:
      - Include upstream patch and changes to fix an issue where the ffmpeg
        media handler does not work due to deprecated api. (LP: #1253468)
 -- Thomas Ward <email address hidden> Fri, 24 Jan 2014 12:54:40 -0500

Changed in gnash (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Sami Jaktholm (sjakthol) wrote :

The version in saucy-proposed fixed the issue also.

tags: added: verification-done-saucy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnash - 0.8.11~git20120629-1ubuntu3.1

---------------
gnash (0.8.11~git20120629-1ubuntu3.1) saucy-proposed; urgency=low

  * New upstream patch:
    + debian/patches/fix-ffmpeg-media-handler.patch:
      - Include upstream patch and changes to fix an issue where the ffmpeg
        media handler does not work due to deprecated api. (LP: #1253468)
 -- Thomas Ward <email address hidden> Thu, 23 Jan 2014 13:33:41 -0500

Changed in gnash (Ubuntu Saucy):
status: Fix Committed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

quantal has seen the end of its life and is no longer receiving any updates. Marking the quantal task for this ticket as "Won't Fix".

Changed in gnash (Ubuntu Quantal):
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.