Ubuntu
wireshark package

Wireshark 1.10.5-1 FTBFS in trusty-proposed, due to multiple reasons

Bug #1269197 reported by Thomas Ward
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Wireshark
Unknown
Unknown
wireshark (Ubuntu)
Fix Released
High
Unassigned

Bug Description

In trusty-proposed, wireshark 1.10.5-1 fails to build from source.

The build log for this is at https://launchpadlibrarian.net/162346177/buildlog_ubuntu-trusty-amd64.wireshark_1.10.5-1_FAILEDTOBUILD.txt.gz

----

I looked into this, as I use the latest wireshark as part of the networking courses I am taking, and figured out that this is handled upstream. The upstream bug is here: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9340

The FTBFS in the version in trusty-proposed is introduced by the configure.ac file not permitting the use of deprecated features.

Upstream revisions to wireshark have permitted the software to build by allowing the use of deprecated features. Upstream has not said that they would fix the issue of deprecated features because they are moving to Qt in some future release according to that upstream bug.

The upstream patch, when applied, correctly fixes the FTBFS that is listed in the aforementioned build log. That patch is here: http://anonsvn.wireshark.org/viewvc/trunk/configure.ac?r1=54337&r2=54336&pathrev=54337&view=patch

However, that patch is insufficient to fix the FTBFS. Through testing with the upstream patch, there are additional FTBFS problems, and according to upstream, this is due to the C99 `g_memmove()` function not existing in recent glib versions. Therefore, Wireshark upstream has fallen back to using the C90 `memmove()` function.

----

The attached debdiff contains the following changes that should resolve the FTBFS:

* Update maintainer field with `update-maintainer` command, which may not be necessary. (This change was done to satisfy `debuilder -S` so that the package could build for testing inside of sbuild schroots.)
* Add new patch debian/patches/allow-deprecated-gtk-functions.patch, which contains code derived from the upstream patch to allow the use of deprecated commands if Gtk is 3.10 or newer
* Add new patch debian/patches/fix-g_memmove-ftbfs-issues.patch, authored by Thomas Ward (teward), to replace instances of `g_memmove()` with `memmove()` to fix additional FTBFS problems.
* New debian/changelog entry describing these changes.

See original description
Tags: ftbfs
Thomas Ward (teward)
description: updated
Thomas Ward (teward)
summary: - Wireshark FTBFS in trusty-proposed, due to multiple reasons
+ Wireshark 1.10.5-1 FTBFS in trusty-proposed, due to multiple reasons
tags: added: ftbfs
Revision history for this message
Thomas Ward (teward) wrote :

I am setting a "High" importance on it according to the wiki documentation of Bug Importance (https://wiki.ubuntu.com/Bugs/Importance). This is because the FTBFS prevents the software version from building and working.

Changed in wireshark (Ubuntu):
importance: Undecided → High
Revision history for this message
Evan Huus (eapache) wrote :

Hi, thanks for the detailed report. Just so you're aware, I have added the appropriate upstream fixes to Wireshark's stable backport list, so Wireshark 1.10.6 (whenever it is released) should compile correctly without any patches.

Unfortunately Wireshark doesn't have an Ubuntu-specific maintainer at this point, so I would suggest that you forward this report to Debian.

Cheers,
Evan

Revision history for this message
Thomas Ward (teward) wrote :

Evan:

I am aware Upstream has this fixed, but unless 1.10.6 is in Debian before February 20, it'll not make it in here, so in the off chance that 1.10.6 isn't an option, this patch should fix the FTBFS in trusty-proposed. (I'm also aware that upstream has this fix because that's where I looked first for this bugfix :P)

I am also aware that there is no Ubuntu maintainer for wireshark, like many other packages in Ubuntu universe. That's why the Ubuntu Sponsors Team is subscribed to this, so they can poke the patch into trusty-proposed to fix the FTBFS there. That does not require any official Ubuntu maintainer for the package either. I have many examples of this, as well, with the uploads I've had sponsored for nginx and znc, which also have no Ubuntu maintainer.

I may consider forwarding this to Debian, but the question I have first is, does this FTBFS in Debian? If it does, I'll forward this information to Debian along with the patch I authored, if it does not, then I don't have to bother Debian unnecessarily.

Revision history for this message
Thomas Ward (teward) wrote :

I made a mistake in the initial debdiff.

I've attached one that includes this bug number so it gets autoclosed if/when the debdiff is included.

Revision history for this message
Evan Huus (eapache) wrote :

Sorry, missed the ubuntu-sponsors subscription.

Debian is currently building with GTK 3.8, so it works for them (for now). I don't know when they plan to migrate to 3.10, but it's been out since September so I expect they'll move soonish.

I believe Balint (debian maintainer) monitors ubuntu bugs as well, so you might not have to do anything at all.

Revision history for this message
Martin Pitt (pitti) wrote :

Many thanks Thomas, this looks fine! I'll do a test-build and sponsor with a fixed version number (ubuntu1, not ubuntu0.1).

Changed in wireshark (Ubuntu):
status: New → In Progress
Martin Pitt (pitti)
Changed in wireshark (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

> I am aware Upstream has this fixed, but unless 1.10.6 is in Debian before February 20, it'll not make it in here.

It will make it here, we usually monitor and sync bug fixes from Debian during most of the development cycle.

Fixing Ubuntu-specific FTBFS bugs directly is also fine, of course (Debian sid doesn't have Gtk 3.10 yet).

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package wireshark - 1.10.5-1ubuntu1

---------------
wireshark (1.10.5-1ubuntu1) trusty; urgency=low

  * Include new patches to fix FTBFS issues: (LP: #1269197)
    + debian/patches/allow-deprecated-gtk-functions.patch:
      - Incorporate upstream changes to fix the FTBFS caused by functions
        deprecated in GTK 3.10 and newer.
    + debian/patches/fix-g_memmove-ftbfs-issues.patch:
      - Replace instances of C99 `g_memmove()` with C90 `memmove()` to fix
        additional FTBFS issues.
  * Update maintainer field.
 -- Thomas Ward <email address hidden> Tue, 14 Jan 2014 19:15:46 -0500

Changed in wireshark (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Balint Reczey (rbalint) wrote :

@Thomas: Thank you for the patch. I have just uploaded wireshark 1.10.5-2 incorporating it to unstable.

While GTK+3.10 in not in unstable, it is in experimental and fixing FTBFS with it in other packages is definitely something to be fixed in unstable even before upstreams take action.
In similar cases feel free to contact me/BTS to have the fix applied in Debian, too.

I noticed this bug a few hours later than it got fixed. Evan was right, giving some more time (maybe a full day ;-)) to me to notice the bug and fix it in Debian would have allowed Ubuntu to simply sync the new package.

Thank you again for the patch and the test builds anyway.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.