tools do not handled abbreviated toplevel slots and plugs syntax correctly

Bug #1595184 reported by Jamie Strandboge
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Fix Released
Medium
Celso Providelo
click-reviewers-tools (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
This is already fixed in the store so the SRU is for users to not see this failure their local system.

[Test Case]
Attached is a test snap

$ snap-review ./snap-example-1595184_0_all.snap
./snap-example-1595184_0_all.snap: pass

[Regression Potential]
Regression potential is extremely low since this is already on production in the Ubuntu Store for many weeks.

= Original description =
This should be valid, but the review tools flag as an error:

apps:
  networkmanager:
    command: command-networkmanager.wrapper
    daemon: simple
    slots:
    - service
  nmcli:
    command: command-nmcli.wrapper
    plugs:
    - nmcli
architectures:
- amd64
confinement: strict
description: ...
name: network-manager

plugs:
  nmcli: network-manager
slots:
  service: network-manager
summary: Network management framework
version: 1.2.2-1

With the above, the tools error with:

unknown interface 'service' lint-snap-v2_slots (service, service)
unknown interface 'nmcli' lint-snap-v2_plugs (nmcli, nmcli)

Related branches

Changed in click-reviewers-tools:
status: New → Triaged
importance: Undecided → Medium
description: updated
Celso Providelo (cprov)
Changed in click-reviewers-tools:
assignee: nobody → Celso Providelo (cprov)
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Fixed in r684.

Changed in click-reviewers-tools:
status: Triaged → Fix Released
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Fixed in upstream 0.44 and in 16.10.

Changed in click-reviewers-tools (Ubuntu Yakkety):
status: New → Fix Released
Changed in click-reviewers-tools (Ubuntu Xenial):
status: New → In Progress
Revision history for this message
Jamie Strandboge (jdstrand) wrote :
description: updated
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Jamie, or anyone else affected,

Accepted click-reviewers-tools into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/click-reviewers-tools/0.44~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in click-reviewers-tools (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

$ click-review ~/Downloads/snap-example-1595184_0_all.snap
/home/jamie/Downloads/snap-example-1595184_0_all.snap: pass

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package click-reviewers-tools - 0.44~16.04.1

---------------
click-reviewers-tools (0.44~16.04.1) xenial-proposed; urgency=medium

  [ Jamie Strandboge ]
  * data/apparmor-easyprof-ubuntu.json:
    - add pulseaudio interface
    - add bluetooth policy group for Touch for 15.04 and higher
    - add location-observe and location-control
    - move all core interfaces to 'common'
    - add gsettings interface
    - set home to auto-approve
    - add mpris interface
    - add camera interface
    - add optical-drive interface
    - add serial-port interface
    - add content interface
  * clickreviews/common.py:
    - don't fail on libmvec.so since it comes from libc6 too (LP: #1584346)
    - extend the regex to also match ld-linux-x86-64.so.2
  * sr_common.py:
    - update _verify_pkgname() and _verify_appname() to use the same regex as
      in snapd and various tests
    - update attributes to be slots or plugs side and cleanup code for
      specifying attributes
  * bin/click-review, clickreviews/modules.py: exit '1' if error with
    init_object or running checks
  * sr_lint.py:
    - support 'environment' key in yaml (LP: #1583259)
    - support 'confinement' key in yaml
  * sr_security.py:
    - specifying mpris slot should not warn
    - adjust profile name length checks to use series 16 security label format
  * run_tests: exit non-zero with failures, errors or unexpectedSuccesses
  * cr_lint.py:
    - 'puritine' is a known, but redflagged hook
    - skip external symlinks and md5sums checks for puritine (since we expect
      external symlinks and the hash checks fail on broken symlinks)
    - 'puritine' hook should not be used with 'apparmor'
  * clickreviews/apparmor_policy.py: adjust for rename of store team
    (LP: #1608943)

  [ Celso Providelo ]
  * support for interface abbreviated syntax (LP: #1595184)

 -- Jamie Strandboge <email address hidden> Tue, 02 Aug 2016 08:43:31 -0500

Changed in click-reviewers-tools (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Jamie Strandboge (jdstrand) wrote : Update Released

The verification of the Stable Release Update for click-reviewers-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.