[SRU] 2.17.1

Bug #1637215 reported by Michael Vogt
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
snapd (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

This is a new version of snapd.

The changelog for 2.17 is available here https://github.com/snapcore/snapd/blob/2.17/debian/changelog, the raw git changelog is available here: https://github.com/snapcore/snapd/commits/2.17 (note that the debian changelog is auto-generated from the merges of the git commits so there is usually no need to look at the raw git commits).

The snappy team released a new 2.17 micro release that we want SRU into xenial. The new process described in https://wiki.ubuntu.com/SnapdUpdates was used and we have done integration-tests on the snappy images, autopkgtests on classic and unit tests.

The following automatic tests are run:
- travis unit tests https://travis-ci.org/snapcore/snapd/branches (check for 2.17 here)
- travis/spread based integration/system tests: https://travis-ci.org/snapcore/snapd/branches (check for 2.17 here under "spread")

The following additional tests were performed:
"""
$ adt-run -s -U snapd_2.17.dsc --- qemu ~/VM/adt-xenial-amd64-cloud.img
[lots of output, wait 45min]
2016/09/28 11:51:57 Restoring autopkgtest:ubuntu-16.04-64:tests/upgrade/...
2016/09/28 11:52:00 Discarding autopkgtest:ubuntu-16.04-64...
2016/09/28 11:52:01 Successful tasks: 88
2016/09/28 11:52:01 Aborted tasks: 0
adt-run [11:52:01]: test integrationtests: -----------------------]
adt-run [11:52:02]: test integrationtests: - - - - - - - - - - results - - - - - - - - - -
integrationtests PASS
adt-run [11:52:03]: @@@@@@@@@@@@@@@@@@@@ summary
integrationtests PASS

$ adt-run -s -U snapd_2.17.dsc --- qemu ~/VM/adt-yakkety-amd64-cloud.img
[lots of output, wait 45min]
2016/09/28 12:09:09 Restoring autopkgtest:ubuntu-16.04-64:tests/upgrade/...
2016/09/28 12:09:12 Discarding autopkgtest:ubuntu-16.04-64...
2016/09/28 12:09:12 Successful tasks: 88
2016/09/28 12:09:12 Aborted tasks: 0
adt-run [12:09:13]: test integrationtests: -----------------------]
adt-run [12:09:14]: test integrationtests: - - - - - - - - - - results - - - - - - - - - -
integrationtests PASS
adt-run [12:09:14]: @@@@@@@@@@@@@@@@@@@@ summary
integrationtests PASS

"""
Almost all of our spread integration tests are now run as part of the autopkgtest run.

After installing the new snapd it was ensured that apt is unaffected by doing:
"""
- sudo apt install -y hello && sudo apt remove -y hello
"""

After installing the new snapd gnome-software was used:
"""
- install "http" (snap) and remove it again
"""
All worked as expected.

Revision history for this message
Andy Whitcroft (apw) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted snapd into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.17.1+16.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapd (Ubuntu Yakkety):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Andy Whitcroft (apw) wrote :

Hello Michael, or anyone else affected,

Accepted snapd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.17.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapd (Ubuntu Xenial):
status: New → Fix Committed
Michael Vogt (mvo)
summary: - [SRU] 2.17
+ [SRU] 2.17.1
Changed in snapd (Ubuntu Vivid):
status: New → Invalid
Changed in snapd (Ubuntu):
status: New → Fix Released
tags: added: verification-done
removed: verification-needed
tags: added: verification-needed
removed: verification-done
Revision history for this message
Federico Gimenez (fgimenez) wrote :

Verification done following [1], all steps performed, specifically:

+ Verified bugs associated to the SRU affecting the user interface.
+ Done exploratory testing (install/uninstall snaps, list interfaces, connect/disconnect plugs, search, list snaps, list changes).
+ Verified new features from changelog.
+ Verified actual upgrade from 2.16ubuntu3 to 2.17.1 and uninstall.
+ Checked interaction with classic apt install and update of debs.

[1] https://wiki.ubuntu.com/SnapdUpdates

tags: added: verification-done
removed: verification-needed
Revision history for this message
Iain Lane (laney) wrote :

In case you weren't aware, it seems this adds a new dependency on xdelta, and xdelta is in universe. IOW, a component mismatch. The same is observed in zesty atm.

Revision history for this message
Iain Lane (laney) wrote :

I'll put it back to v-needed to prevent any accidents. This is making snapd not be on daily images, because they build from proposed and this is a recommends.

tags: added: verification-needed
removed: verification-done
Revision history for this message
Mark Shuttleworth (sabdfl) wrote : Re: [Bug 1637215] Re: [SRU] 2.17.1

Perhaps xdelta[3] should be part of the snapd package, not a dep?

Mark

Revision history for this message
Martin Pitt (pitti) wrote :

This is not fixed in zesty yet, as it's blocked in -proposed on several test failures: http://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html#snapd

This also blocks the SRU release, in addition to the new xdelta universe dependency.

Changed in snapd (Ubuntu):
status: Fix Released → Fix Committed
Revision history for this message
Michael Vogt (mvo) wrote :

The xdelta universe dependency got removed, we will most likely switch to xdelta3 in the next release. I'm investigating the autopkgtest problem now.

Revision history for this message
Steve Langasek (vorlon) wrote :

2.17.1ubuntu1 which drops the xdelta dependency has been accepted into -proposed; it failed to build on s390x, but this looks like a possible flaky test so I've retried the build now and it succeeded.

Both 2.17.1 and 2.17.1ubuntu1 FTBFS on armhf, with a consistent test failure:

FAIL: state_test.go:223: stateSuite.TestImplicitCheckpointPanicsAfterFailedRetries

state_test.go:241:
    // we did at least a couple
    c.Check(retries > 2, Equals, true)
... obtained bool = false
... expected bool = true

OOPS: 74 passed, 1 FAILED
--- FAIL: TestState (0.25s)
FAIL
FAIL github.com/snapcore/snapd/overlord/state 0.282s

(https://launchpad.net/ubuntu/+source/snapd/2.17.1/+build/11144582)

So 2.17.1 doesn't look releasable. Would 2.18 fix this build-time test failure?

Revision history for this message
Steve Langasek (vorlon) wrote :

looks like the armhf failure is also intermittent; package built successfully on a retry.

Revision history for this message
Michael Vogt (mvo) wrote :

@Steve thanks for the retry, I pushed a fix for this test failure to git now https://github.com/snapcore/snapd/pull/2364 - sorry for the trouble.

Revision history for this message
Federico Gimenez (fgimenez) wrote :

I've verified 2.17.1ubuntu1, all seems to be working fine:

+ Done exploratory testing (install/uninstall snaps, list interfaces, connect/disconnect plugs, search, list snaps, list changes).
+ Verified actual upgrade from 2.16ubuntu3 to 2.17.1ubuntu1 and uninstall.
+ Checked interaction with classic apt install and update of debs.

Cheers,

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapd - 2.18+17.04ubuntu3

---------------
snapd (2.18+17.04ubuntu3) zesty; urgency=medium

  * disable ppc64el autopkgtest for now, it never worked but for
    some reason autopkgtest thinks it did at some point and asking
    for correction of the DB was not successful so far

 -- Michael Vogt <email address hidden> Fri, 02 Dec 2016 16:27:34 +0100

Changed in snapd (Ubuntu):
status: Fix Committed → Fix Released
Mathew Hodson (mhodson)
no longer affects: snapd (Ubuntu Vivid)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted snapd into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.17.1+16.10ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
Revision history for this message
Michael Terry (mterry) wrote :

Looks like the verification-done tag for xenial got overridden when the yakkety version got added to this bug. I'll add the verification-done-xenial tag.

tags: added: verification-done-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (11.2 KiB)

This bug was fixed in the package snapd - 2.17.1ubuntu1

---------------
snapd (2.17.1ubuntu1) xenial; urgency=medium

  * drop xdelta dependency

snapd (2.17.1) xenial; urgency=medium

  * New upstream release, LP: #1637215:
    - release: os-release on core has changed
    - tests: /dev/ptmx does not work on powerpc, skip here
    - docs: moved to github.com/snapcore/snapd/wiki (#2258)
    - debian: golang is not installable on powerpc, use golang-any

snapd (2.17) xenial; urgency=medium

  * New upstream release, LP: #1637215:
    - overlord/ifacestate: add unit tests for undo of setup-snap-
      security (#2243)
    - daemon,overlord,snap,tests: download to .partial in final dir
      (#2237)
    - overlord/state: marshaling tests for lanes (#2245)
    - overlord/state: introduce state lanes (#2241)
    - overlord/snapstate: fix revert+refresh (#2224)
    - interfaces/sytemd: enable/disable generated service units (#2229)
    - many: fix incorrect security files generation on undo
    - overlord/snapstate: add dynamic snapdX.Y assumes (#2227)
    - interfaces: network-manager: give slot full read-write access to
      /run/NetworkManager
    - docs: update the name of the command for the cross-build
    - overlord/snapstate: fix missing argument to Noticef
    - snapstate: ensure gadget/core/kernel can not be disabled (#2218)
    - asserts: limit to 1y only if len(models) == 0 (#2219)
    - debian: only install share/locale if available (missing on
      powerpc)
    - overlrod/snapstate: fix revert followed by refresh to old-current
      (#2214)
    - interfaces/builtin: network-manager and bluez can change hostname
      (#2204)
    - snap: switch the auto-import dir to /run/snapd/auto-import
    - docs: less details about cloud.cfg as requested in trello (#2206)
    - spread.yaml: Ensure ubuntu user has passwordless sudo for
      autopkgtests (#2201)
    - interfaces/builtin: add dcdbas-control interface
    - boot: do not set boot to try mode if the revision is unchanged
    - interfaces: add shutdown interface (#2162)
    - interfaces: add system-power-control interface
    - many: use the new systemd backend for configuring GPIOs
    - overlord/ifacestate: setup security for slots before plugs
    - snap: spool assertion candidates if snapd is not up yet
    - store,daemon,overlord: download things to a partials dir
    - asserts,daemon: implement system-user-authority header/concept
    - interfaces/builtin: home base declaration rule using on-classic
      for its policy
    - interfaces/builtin: finish decl based checks
    - asserts: bump snap-declaration to allow signing with new-style
      plugs and slots
    - overlord: checks for kernel installation/refresh based on model
      assertion and previous kernel
    - tests/lib/fakestore: fix logic to distinguish assertion not found
      errors
    - client: add a few explicit error types (around the request cycle)
    - tests/lib/fakestore/cmd/fakestore: make it log, and fix a typo
    - overlord/snapstate: two bugs for one
    - snappy: disable auto-import of assertions on classic (#2122)
    - overlord/snapstate: move trash cleanup to a cleanup handler
      (#2173)
    -...

Changed in snapd (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapd - 2.20.1+16.10ubuntu2

---------------
snapd (2.20.1+16.10ubuntu2) yakkety; urgency=medium

  * New upstream release, LP: #1648520
    - spread.yaml: update for ppc64el, i386, armhf

 -- Michael Vogt <email address hidden> Tue, 03 Jan 2017 22:16:08 +0100

Changed in snapd (Ubuntu Yakkety):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.