Ubuntu 16.04 package version contains improper API

Bug #1646914 reported by bp-art
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
yaml-cpp (Ubuntu)
Fix Released
Undecided
Gianfranco Costamagna
Xenial
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
A call to equals was broken by an API change, and one of the calls in the header was never updated.

/usr/include/yaml-cpp/node/detail/impl.h:136:15: error: ‘equals’ was not declared in this scope
     if (equals(*it->first, key, pMemory)) {

This is fixed in the 0.5.3 source.
[ Test case ]
* Try to use the package on xenial
[ Regression potential ]
* Low risk, since the current package is unusable.

Revision history for this message
bp-art (bp-art) wrote :

0.5.2 does not compile in Ubuntu 16.04. Please consider promoting 0.5.3 to LTs.

https://github.com/jbeder/yaml-cpp/pull/303#issuecomment-264642971

Revision history for this message
bp-art (bp-art) wrote :

I should have said that the headers for 0.5.2 cannot be included in any program being compiled as the API is broken is the head of 0.5.2. Unsure why this wasn't caught by the package maintainers before but it's causing serious issues wit people using yank-cop. (The entire ROS community) trying to upgrade to 16.04 from 14.04.

Revision history for this message
bp-art (bp-art) wrote :

This PPA uses 0.5.3 instead of 0.5.2 (which has been out for over a year) and works fine.

https://launchpad.net/~winterheart/+archive/ubuntu/openxcom

Revision history for this message
bp-art (bp-art) wrote :

Is there a way to allow Azamat Hackimov's packages to become the new Ubuntu standard over the ones in Debian Sid?

Revision history for this message
bp-art (bp-art) wrote :

Bump.

Revision history for this message
Azamat H. Hackimov (winterheart) wrote :

Hello.

yaml-cpp is maintained by Debian. If need to version bump, you need to direct your request to them.

Revision history for this message
bp-art (bp-art) wrote :

I have. The package maintainer seems to be a (former) grad student that is completely unresponsive. Since he/Debian doesn't seem to care, I was hoping Canonical would since their LTS OS has a noncompiling header.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in yaml-cpp (Ubuntu):
status: New → Confirmed
Revision history for this message
bp-art (bp-art) wrote : Re: [Bug 1646914] Re: Ubuntu 16.04 package version contains improper API

BtW this is fixed in 16.10 but the fixes were never ported to 16.04. My
company's fix in the meantime us just been to install the 16.10 deb files
using dpkg. Works great.
On Wed, May 17, 2017 at 5:30 PM Launchpad Bug Tracker <
<email address hidden>> wrote:

> Status changed to 'Confirmed' because the bug affects multiple users.
>
> ** Changed in: yaml-cpp (Ubuntu)
> Status: New => Confirmed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1646914
>
> Title:
> Ubuntu 16.04 package version contains improper API
>
> Status in yaml-cpp package in Ubuntu:
> Confirmed
>
> Bug description:
> A call to equals was broken by an API change, and one of the calls in
> the header was never updated.
>
> /usr/include/yaml-cpp/node/detail/impl.h:136:15: error: ‘equals’ was not
> declared in this scope
> if (equals(*it->first, key, pMemory)) {
>
>
> This is fixed in the 0.5.3 source.
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/yaml-cpp/+bug/1646914/+subscriptions
>

Revision history for this message
bp-art (bp-art) wrote :

It would be great if the Ubuntu maintainers could allows the 16.10 packages for libyaml-cpp to get pushed out with 16.04. These libraries are unusable in 16.04 but work fine to installed the 16.10 versions. The issues are that CI builds using Docker images require extra steps to get these packages in them that keep all my CI stuff forked from my community that doesn't necessarily care about libyaml-cpp.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

please test the package in please test the package on ppa:costamagnagianfranco/locutusofborg-ppa

Changed in yaml-cpp (Ubuntu):
status: Confirmed → In Progress
description: updated
Changed in yaml-cpp (Ubuntu):
assignee: nobody → LocutusOfBorg (costamagnagianfranco)
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello bp-art, or anyone else affected,

Accepted yaml-cpp into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/yaml-cpp/0.5.2-4ubuntu1~16.04.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in yaml-cpp (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

I checked, and the code is now looking correct!

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
bp-art (bp-art) wrote :

Fix works. Thanks

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thanks for verifying! From the formal POV, could you please report which version has been used for validation?

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Installing 0.5.2-4ubuntu1~16.04.4 dragged in the fix in the header file.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

(on xenial system)

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for yaml-cpp has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yaml-cpp - 0.5.2-4ubuntu1~16.04.4

---------------
yaml-cpp (0.5.2-4ubuntu1~16.04.4) xenial; urgency=medium

  * SRU the package to xenial, to fix various issues
    that makes the package unusable:
    - LP: #1318940: adding boost dependency
    - LP: #1646914: fix API incompatibility

yaml-cpp (0.5.2-4ubuntu1) zesty; urgency=medium

  * debian/patches/303.patch:
    fix build failures when using yaml-cpp
    (upstream pull request 303)
    - see debian bug #847099)

yaml-cpp (0.5.2-4) unstable; urgency=medium

  * Make the build reproducible (Closes: #808714)
  * Add libboost-dev dependency (Closes: #812851)
  * Fix yaml-cpp 0.5.2 issue (Closes: #814499)
  * Fix lintian warnings: spelling, standards-version, and Vcs-Git

yaml-cpp (0.5.2-3.1) unstable; urgency=medium

  * Non-maintainer upload.
  * Work around bug in googletest causing segfault with gcc-6.
    (Closes: #812284)

 -- Gianfranco Costamagna <email address hidden> Mon, 20 Aug 2018 16:04:33 +0200

Changed in yaml-cpp (Ubuntu Xenial):
status: Fix Committed → Fix Released
Changed in yaml-cpp (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.