test-umockdev tests flaky on armhf (and sometimes other archs)

Bug #1831467 reported by Dan Streetman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
umockdev (Ubuntu)
Fix Released
Low
Dan Streetman
Xenial
Won't Fix
Low
Unassigned
Bionic
Fix Released
Low
Dan Streetman
Focal
Fix Released
Low
Dan Streetman
Groovy
Fix Released
Low
Dan Streetman

Bug Description

[impact]

these tests fail intermittently, due to various timing issues, as well as an actual code bug in how data fuzz is calculated.

it looks like the failures are mostly on armhf, but do happen less often on other archs.

[test case]

check the previous autopkgtest logs, e.g.
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic/cosmic/armhf/u/umockdev/20190601_015323_8f795@/log.gz

[regression potential]

any regression would likely result in incorrectly failing/passing autopkgtests, or in a incorrect pass or incorrect fail of the ScriptRunner
to verify the data's level of fuzz.

[scope]

as the tests are flaky on armhf all the way back to trusty, this is needed for all releases.

[other info]

Fixed upstream in PR https://github.com/martinpitt/umockdev/pull/103

Most of the changes are test case fixes, but there is one fix to source code to fix the ScriptRunning function that validates the level of fuzz in data, so this is not *only* a testcase fix.

Dan Streetman (ddstreet)
summary: - 'testbed_script_replay_simple' test fails intermittently
+ test-umockdev tests flaky on armhf
Dan Streetman (ddstreet)
description: updated
Dan Streetman (ddstreet)
summary: - test-umockdev tests flaky on armhf
+ test-umockdev tests flaky on armhf (and sometimes other archs)
Dan Streetman (ddstreet)
Changed in umockdev (Ubuntu Groovy):
assignee: nobody → Dan Streetman (ddstreet)
Changed in umockdev (Ubuntu Focal):
assignee: nobody → Dan Streetman (ddstreet)
Changed in umockdev (Ubuntu Bionic):
assignee: nobody → Dan Streetman (ddstreet)
Changed in umockdev (Ubuntu Xenial):
assignee: nobody → Dan Streetman (ddstreet)
Changed in umockdev (Ubuntu Groovy):
importance: Undecided → Low
Changed in umockdev (Ubuntu Focal):
importance: Undecided → Low
Changed in umockdev (Ubuntu Bionic):
importance: Undecided → Low
Changed in umockdev (Ubuntu Xenial):
importance: Undecided → Low
Changed in umockdev (Ubuntu Groovy):
status: New → In Progress
Changed in umockdev (Ubuntu Focal):
status: New → In Progress
Changed in umockdev (Ubuntu Bionic):
status: New → In Progress
Changed in umockdev (Ubuntu Xenial):
status: New → In Progress
Dan Streetman (ddstreet)
description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

https://salsa.debian.org/debian/umockdev/-/commit/87b476aee2 should hopefully help. I uploaded 0.14.2 to Debian unstable now, it should auto-sync into Groovy soon. Thanks Dan for tackling this!

Changed in umockdev (Ubuntu Groovy):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package umockdev - 0.14.2-1

---------------
umockdev (0.14.2-1) unstable; urgency=medium

  * New upstream version 0.14.2:
    - preload: Fix incomplete reads scripts
    - tests: Fix incomplete reads for fuzzy script tests
      (Closes: #767908)
    - tests: Add $SLOW_TESTBED_FACTOR env var for slow architectures
  * Make autopkgtest robust for slow testbeds.
    Set the new `$SLOW_TESTBED_FACTOR` to avoid frequent failures on armhf
    and other slow/shared distro CI hardware. (LP: #1831467)
  * debian/rules: Add hack for code coverage related autoconf regression.

 -- Martin Pitt <email address hidden> Wed, 29 Jul 2020 18:08:15 +0200

Changed in umockdev (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dan, or anyone else affected,

Accepted umockdev into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/umockdev/0.14.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in umockdev (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Changed in umockdev (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Dan, or anyone else affected,

Accepted umockdev into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/umockdev/0.11.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Dan Streetman (ddstreet) wrote :

all tests pass for b and f (except the expected i386 failure on f, of course)

tags: added: verification-done verification-done-bionic verification-done-focal
removed: verification-needed verification-needed-bionic verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package umockdev - 0.11.1-1ubuntu0.1

---------------
umockdev (0.11.1-1ubuntu0.1) bionic; urgency=medium

  * d/p/lp1831467/0001-src-umockdev.vala-fix-ScriptRunner.op_write.patch,
    d/p/lp1831467/0002-tests-read-expected-number-of-bytes-maybe-over-multi.patch,
    d/p/lp1831467/0003-tests-test-umockdev-record.vala-add-slow_testbed_fac.patch,
    d/p/lp1831467/0004-tests-test-umockdev.c-add-slow_testbed_factor-variab.patch,
    d/p/lp1831467/0005-tests-test-umockdev-run.vala-add-slow_testbed_factor.patch,
    d/p/lp1831467/0006-remove_SocketServer_ctrl-r_assert.patch,
    d/rules, d/t/upstream:
    - Fix various timing-related tests
      Fix ScriptRunner fuzz checking function
      (LP: #1831467)

 -- Dan Streetman <email address hidden> Thu, 06 Aug 2020 20:43:44 -0400

Changed in umockdev (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for umockdev has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package umockdev - 0.14.1-1ubuntu0.1

---------------
umockdev (0.14.1-1ubuntu0.1) focal; urgency=medium

  * d/p/lp1831467/0001-src-umockdev.vala-fix-ScriptRunner.op_write.patch,
    d/p/lp1831467/0002-tests-read-expected-number-of-bytes-maybe-over-multi.patch,
    d/p/lp1831467/0003-tests-test-umockdev-record.vala-add-slow_testbed_fac.patch,
    d/p/lp1831467/0004-tests-test-umockdev.c-add-slow_testbed_factor-variab.patch,
    d/p/lp1831467/0005-tests-test-umockdev-run.vala-add-slow_testbed_factor.patch,
    d/p/lp1831467/0006-remove_SocketServer_ctrl-r_assert.patch,
    d/rules, d/t/upstream:
    - Fix various timing-related tests
      Fix ScriptRunner fuzz checking function
      (LP: #1831467)

 -- Dan Streetman <email address hidden> Thu, 06 Aug 2020 20:39:01 -0400

Changed in umockdev (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Dan Streetman (ddstreet) wrote :

marking as wontfix for xenial, as i won't get to it

Changed in umockdev (Ubuntu Xenial):
assignee: Dan Streetman (ddstreet) → nobody
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.