Ubiquity installer in Hardy can loop at partition editing step

Bug #235374 reported by Glenn McDonald
6
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
Medium
Evan
Hardy
Fix Released
Undecided
Unassigned

Bug Description

The installer fails to reset the variable that causes it to stay on a page when an error is triggered when returning to a previous page, causing it to stay on the previous page that it just returned to despite any attempts to proceed.

This will occur if a user enters an invalid password, then presses back to change their partition layout. If they try to proceed forward to the user setup page again, they will remain on the partitioning page.

This is a one line change that should have no regressions.

A diff of the proposed change as included in the ubiquity 1.8.9 upload can be found here:

TEST CASE:
1) Run the installer, click "Forward" until you get to Step 5, Who are you?
2) Enter all data correctly except for the "What is the name of this computer?" field - enter a name with an underscore (or presumably any other non-valid character) and press "Forward"
3) The installer will complain that the computer name is invalid.
4) Click "Back" to go back to Step 4, the partition editor
5) Press "Forward" - partition editor rescans the disk and step 4 starts again (this will happen every time you press "Forward", and happens regardless of what settings you choose for the partitions.)

Original report:
There is a sequence of events that can cause the Ubiquity installer in Hardy Herron (8.04) to loop at step 4, the partitioning step.

Evan (ev)
Changed in ubiquity:
assignee: nobody → evand
importance: Undecided → Medium
status: New → Confirmed
Evan (ev)
Changed in ubiquity:
status: Confirmed → Fix Committed
Revision history for this message
Evan (ev) wrote :
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 1.9.0

---------------
ubiquity (1.9.0) intrepid; urgency=low

  [ Colin Watson ]
  * Fix ownership of /home/oem/Desktop in OEM installations (LP: #209683).
  * Silence deprecation warning in zoommap.
  * Add ubiquity-dm implementation for matchbox-window-manager (thanks,
    Patrick Hétu; see LP #159363).
  * Make use of RAWMINSIZE, RAWCURSIZE, and RAWMAXSIZE variables from
    partman-partitioning 59ubuntu2 to set accurate bounds on the resize
    widget.

  [ Evan Dandrea ]
  * Usability fixes for the timezone widget:
    - Make the hover-to-zoom areas relative to the widget size.
    - Zoom in on the location of the cursor, not the edge relative to its
      position.
    - Add a delay for zooming out.
  * Handle the migration-assistant UI being fed non-UTF data gracefully.
  * Make capitalization of migration-assistant consistent (LP: #225555).
  * Remember hostname between runs of ubiquity (LP: #40590).
  * Disable the close button for progress windows (LP: #107686).
  * Reset stay_on_page when the back button is pressed (LP: #235374).

  [ Mario Limonciello ]
  * Enable --automatic and preseeding support on the Mythbuntu frontend.

 -- Evan Dandrea <email address hidden> Mon, 02 Jun 2008 14:26:30 -0400

Changed in ubiquity:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into -proposed, please test and give feedback here

Changed in ubiquity:
status: New → Fix Committed
Revision history for this message
Steve Beattie (sbeattie) wrote :

I have reproduced the looping problem in the original version of ubiquity, 1.8.7, as included with the 8.04 release. I then enabled the proposed repository and installed the current ubiquity in hardy-proposed, 1.8.11, and verified that the looping problem is fixed.

Revision history for this message
Steve Beattie (sbeattie) wrote :

The 8.04 proposed package that addressed this issue was released but this bug was not referred to in the changelog. Marking as fix released.

Changed in ubiquity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.