patch dget to suggest dgetlp

Thank you for taking the time to report this bug and helping to make Ubuntu better. What you submitted is not really a bug, or a problem in the current implementation of the software, but rather a feature request. Ubuntu has a site for collecting new ideas just like this and I encourage you to submit to http://brainstorm.ubuntu.com/

Anthony, this seems pretty simple - not every feature request has to go to brainstorm.

I modified scripts/dget.pl to die if a file from launchpadlibrarian.net was requested. When it dies, it displays this message in the terminal:

"Use dgetlp provided by ubuntu-dev-tools for files hosted at launchpadlibrarian.net."

Since we are telling them to use dgetlp, I also added ubuntu-dev-tools as a recommended package. apt now installs recommended packages automatically, so this will cause ubuntu-dev-tools to be installed along with devscripts. As a result, they won't have any issues running dgetlp.

The debdiff includes changes to debscripts.pot fr.po. From the looks of it, this is because I added lines to dget.pl. As a result, the line numbers for the translations had to be modified. If these changes are not needed in the debdiff, let me know. I would be glad to prepare a new debdiff without them.

devscripts (2.10.26ubuntu8) intrepid; urgency=low

  * scripts/dget.pl
    - Die if trying to download from launchpadlibrarian.net
      and tell user to use dgetlp from ubuntu-dev-tools. (LP: #247172)
  * debian/control
    - Recommend ubuntu-dev-tools

 -- Nathan Handler <email address hidden> Fri, 11 Jul 2008 15:33:20 -0500

You don't need to include the trivial translation changes, but it's no trouble to handle a debdiff that includes them. I've sponsored this now - sorry for the delay, and thanks!

This bug was fixed in the package devscripts - 2.10.26ubuntu9

---------------
devscripts (2.10.26ubuntu9) intrepid; urgency=low

  * scripts/dget.pl
    - Die if trying to download from launchpadlibrarian.net
      and tell user to use dgetlp from ubuntu-dev-tools. (LP: #247172)
  * debian/control
    - Recommend ubuntu-dev-tools

 -- Nathan Handler <email address hidden> Tue, 19 Aug 2008 14:18:59 +0100

I'm reverting this fix. Because recommends get installed by default, adding ubuntu-dev-tools to a recommends pulls in a lot of packages and all would have to be in Main.

We discussed this with the Launchpad developers and this only affects PPA packages and is a bug (this was fixed in the main archive some time ago).

On Tue, 2008-08-19 at 20:40 +0000, Scott Kitterman wrote:
> I'm reverting this fix. Because recommends get installed by default,
> adding ubuntu-dev-tools to a recommends pulls in a lot of packages and
> all would have to be in Main.
>
> We discussed this with the Launchpad developers and this only affects
> PPA packages and is a bug (this was fixed in the main archive some time
> ago).
>
> ** Changed in: devscripts (Ubuntu)
> Status: Fix Released => Won't Fix

I'm not sure now - where will this be fixed?
kk

Scott: I disagree. Surely it's useful if you happen to have a URL to a .dsc on launchpadlibrarian.net, regardless of whether it's in a PPA.

If the Recommends is a problem, it would be easy to simply drop this to a Suggests. I'm disappointed that you just reverted this without prior discussion; let's talk about this before taking further action.

Colin: The recommends is a problem as ubuntu-dev-tools is in Universe. Also it ends up pulling in ~70 more packages. Before reverting this I did look for you on IRC and did not find you. We had a discussion with the author of the patch (on #ubuntu-motu) and he agreed with reverting it. We also talked with cprov and he agreed to extending the dget friendly urls provided for Ubuntu packages to PPA.

If you'd been around I certainly would have discussed it with you, but I felt that because of the large number of additional packages this was going to pull into a lot of people's systems and that the effect of the problem was substantially narrower than reported in the bug reversion was appropriate. I'm certain seeing it was reverted seemed abrupt. My apologies for that.

Karl: I think that the best solution for this for Launchpad to fix it. More discussion below.

If this is important enough to fix (I don't think it is, my suggestion is just wait for Launchpad to resolve the problem with PPA as they have done with distro package) I don't think falling back to dgetlp is the right answer. Looking at dgetlp, it appears that the operative bits that are unique to it are captured in a few lines of shell. My suggestion would be to integrate the fallback to dgetlp directly into dget and make it transparent to the user. If we do that, we can just drop dgetlp from ubuntu-dev-tools.

Hmm, OK. I would have dropped it to a Suggests but I guess either works.

Did you get any information on whether Launchpad will get this fixed by the time Ubuntu 7.10 releases? If not, I think we'd be justified in providing folks with that little bit of extra advice for the time being.

I agree that integrating dgetlp into dget is ultimately a better solution (I did look at just execing it, but it doesn't support the same command-line options). Nathan, perhaps you could look at that so that we have it as a fallback?

This bug was fixed in the package devscripts - 2.10.39ubuntu1~hardy1

---------------
devscripts (2.10.39ubuntu1~hardy1) hardy-backports; urgency=low

  * Automated backport upload; no source changes.

devscripts (2.10.39ubuntu1) jaunty; urgency=low

  * Merge from debian unstable; remaining Ubuntu changes:
    - rmadison: Change default URL parameter to ubuntu.
    - scripts/debchange.pl:
      + Adjust --security template for Ubuntu.
      + Add -U/--upstream flag that forces original "just increment
        the end" behaviour; Ubuntu is upstream for some pieces of software.
      + Add --distributor= to override lsb_release output.
      + Add "jaunty" as valid release name.
      + Default to "jaunty" as distribution.
      + Add "ubuntu1" to version string for new versions, with tweaks for
        special cases.
    - Add test/debchange.pl, test/Makefile: debchange test suite; call it
      during build in debian/rules. Also add lsb-release build dependency for
      this, so that debchange uses Ubuntu mode.
    - scripts/debuild.pl: Enforce Ubuntu merge policy.
    - scripts/debsign.{sh,1}: implement DEBSIGN_ALWAYS_RESIGN variable to skip
      the "Would you like to use the current signature?" question. (Debian
      #447955)
    - scripts/uupdate.{sh,1}: Use -0ubuntu1 default revision on Ubuntu.
      (LP #236526)
    - scripts/dscverify.pl: Add Ubuntu keyrings. (LP #228296)
    - Drop universe packages from Recommends to Suggests:
      + libcrypt-ssleay-perl: only needed for a corner case (uscan on SSL
        download sites), wasn't installed by default in previous releases
        either, and seems quite dead upstream
      + libsoap-lite-perl: only needed for one less common command ("select")
        for bts, which isn't useful for Ubuntu itself, and pulls in a lot of
        other universe Perl libraries
      + debian-{keyring,maintainers}: not useful enough in Ubuntu
      + equivs: too much of a hack to install by default
  * Reintroduce desktop2menu. libfile-desktopentry-perl is in main now anyway,
    and reverting the dropping makes the delta to Debian much smaller. It
    doesn't actually hurt to ship it, after all.

devscripts (2.10.39) unstable; urgency=low

  [ Adam D. Barratt ]
  * bts:
    + Allow an explicit HELO to be specified when connecting via SMTP.
    + If a HELO is not specified then attempt to use the content of
      /etc/mailname instread.
    + Expand on the definition of "claim" in the manpage. (Closes: #501142)
    + Trim anything that doesn't look like an e-mail address from $DEBEMAIL or
      $EMAIL before using it for un/claim or un/subscribe. (Closes: #501162)
    + Update the documentation for "bts select" to make it clearer that
      specifying a key multiple times gives "or" semantics. (Closes: #499434)
  * checkbashisms:
    + Recognise brace expansions containing a leading or trailing empty value
      ("{,foo}", etc). Thanks Jonny Lamb. (Closes: #499971)
    + Recognise the use of "source" with quoted arguments. (Closes: #501171)
  * debdiff: Ensure exit status is always explicitly set (and set
    correctly). (Closes: #500256)
  * debian/rules: Create a link from the French pts-subscribe m...