change-override.py -S incorrectly moves binaries no longer built by this source

Bug #32135 reported by Colin Watson
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Julian Edwards

Bug Description

I did the following (along with several other override changes):

$ python /srv/launchpad.net/codelines/change-override_fixed/scripts/ftpmaster-tools/change-override.py -c universe -S mozilla

After the next publisher run, I found that ubuntu-desktop was now uninstallable, and investigated. It turned out that this tool had demoted libnspr-dev, libnspr4, libnss-dev, and libnss3 to universe (without telling me, of course; see bug 31515), despite the fact that the mozilla package in dapper no longer builds any of those binaries; it built them in breezy, but we removed that some time ago in dapper.

Please make sure that -S only affects binaries built by the source package in the suite currently being acted upon.

Tags: lp-soyuz
Revision history for this message
Celso Providelo (cprov) wrote :

I'm affraid only elmo can do this in short-term, but let me know if I can help in anything.

Changed in launchpad-upload-and-queue:
assignee: nobody → elmo
Revision history for this message
Celso Providelo (cprov) wrote :

Since change-override was redesigned, I'm adopting this bug and incriasing the severity to ensure it will get addressed soon.

Changed in qprocd:
assignee: elmo → cprov
status: Unconfirmed → Confirmed
Revision history for this message
Celso Providelo (cprov) wrote :

Julian

It should be easier for you to get into this when you have time (1.1.7).

It's clearly the same side-effect you recently corrected in copy-package, IDASBP-based API is leading us to mistake.

We should move changeOverride & supersede methods to IDASBPR.

Changed in soyuz:
assignee: cprov → julian-edwards
Changed in soyuz:
status: Confirmed → In Progress
Revision history for this message
Julian Edwards (julian-edwards) wrote :

RF 4542

Changed in soyuz:
status: In Progress → Fix Committed
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.