restart broken - Regression Caused by LP: #600941

I'm unfortunately in a bit of a rush with alpha-1 being released next week so don't expect to have time to work on this for the next week or so.

In the mean time, could you forward that bug and fix to Debian? it'd make the process on Ubuntu's side much easier if it gets fixed in Debian first.

Our current init script (the one included in the SRU) is a perfect copy/paste from Debian's, so your bug most likely affects them too and so it'd be the right place to get the fix included.

Thanks

I'm OK with just using my PPA for now and letting the rest of the world stay broken.

http://ubuntuforums.org/showthread.php?t=1886725

I will be on vacation through Jan 5, 2012. Please do not ask for testing until after that date, thanks.

Status changed to 'Confirmed' because the bug affects multiple users.

I'm back, feel free to ask for non-developer QA testing from me. Thanks.

This bug was fixed in the package nagios-nrpe - 2.12-6ubuntu1

---------------
nagios-nrpe (2.12-6ubuntu1) quantal; urgency=low

  [ Dmitrijs Ledkovs ]
  * Merge with Debian; remaining changes:
    - debian/{rules,control}: add hardening-includes to gain PIE
      security builds.
    - Use dpkg-buildflags.
  * Changes gained from Debian:
    - [4dc53fb] Use retry argument for start-stop-daemon when stopping nrpe
    (LP: #896388)

  [ Stéphane Graber ]
  * Drop useless diff file in source package (xxx) that was added by
    mistake in a previous merge.

nagios-nrpe (2.12-6) unstable; urgency=low

  * [36b1062] Add add icinga to the list of recommends
  * [a698acb] Don't remove homedirectory of the nagios user (Closes: #665845)
  * [4dc53fb] Use retry argument for start-stop-daemon when stopping nrpe
    (Closes: #650464)
 -- Stephane Graber <email address hidden> Thu, 03 May 2012 09:55:10 -0400

Hello nutznboltz, or anyone else affected,

Accepted nagios-nrpe into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Hello nutznboltz, or anyone else affected,

Accepted nagios-nrpe into oneiric-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Hello nutznboltz, or anyone else affected,

Accepted nagios-nrpe into natty-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Hello nutznboltz, or anyone else affected,

Accepted nagios-nrpe into hardy-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Hello nutznboltz, or anyone else affected,

Accepted nagios-nrpe into lucid-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I actually accepted the natty-proposed upload now.

Can someone help testing these?

Based on past comments, the two things we want to check for all of these Ubuntu versions are:
 - Does /etc/init.d/nagios-nrpe restart work fine (try calling multiple time) => regression test
 - Does /etc/init.d/nagios-nrpe restart under high load work fine now (in the past, the service would stop but never restart)

Short of having testers willing to confirm the SRU for me, I deployed it on my network, across multiple hosts with varying load, all of the 60 containers upgraded properly and nrpe still works. This was on a mix of hardy (5 systems), lucid (20 systems), precise (75 systems).

So as far as I'm concerned, that's:
 - hardy => OK
 - lucid => OK
 - precise => OK

As natty shipped with the exact same version of nagios-nrpe as lucid's, I'd consider it a pass too (even though I haven't tested it).

I unfortunately don't have any oneiric system using nrpe (I only use LTSes in production) but I'd be tempted to consider it a pass too on the basis that the fix is absolutely identical to lucid's and the previous SRU (2.12-4ubuntu3.1) touching the same code path was confirmed to apply equally on all releases.

Marking verification-done. If someone has time, actual testing of both natty and oneiric would be appreciated.

This bug was fixed in the package nagios-nrpe - 2.8.1-1ubuntu0.2

---------------
nagios-nrpe (2.8.1-1ubuntu0.2) hardy-proposed; urgency=low

  * [4dc53fb] Use retry argument for start-stop-daemon when stopping nrpe,
    this fixes cases where restarting nagios-nrpe fails to respawn it.
    (LP: #896388)
 -- Stephane Graber <email address hidden> Thu, 03 May 2012 10:19:29 -0400

This bug was fixed in the package nagios-nrpe - 2.12-4ubuntu1.10.04.2

---------------
nagios-nrpe (2.12-4ubuntu1.10.04.2) lucid-proposed; urgency=low

  * [4dc53fb] Use retry argument for start-stop-daemon when stopping nrpe,
    this fixes cases where restarting nagios-nrpe fails to respawn it.
    (LP: #896388)
 -- Stephane Graber <email address hidden> Thu, 03 May 2012 10:17:43 -0400

This bug was fixed in the package nagios-nrpe - 2.12-5ubuntu1.1

---------------
nagios-nrpe (2.12-5ubuntu1.1) precise-proposed; urgency=low

  * [4dc53fb] Use retry argument for start-stop-daemon when stopping nrpe,
    this fixes cases where restarting nagios-nrpe fails to respawn it.
    (LP: #896388)
 -- Stephane Graber <email address hidden> Thu, 03 May 2012 10:10:38 -0400

Resetting verification tags for natty and oneiric. These should at least get a shallow regression test ("still starts and works") to rule out misbuilds.

Confirmed on natty, used a clean up to date natty container, installed nagios-nrpe-server, checked that it started properly, upgraded to that from -proposed, checked that the restart worked properly.

Confirmed on oneiric, used a clean up to date oneiric container, installed nagios-nrpe-server, checked that it started properly, upgraded to that from -proposed, checked that the restart worked properly.

This bug was fixed in the package nagios-nrpe - 2.12-4ubuntu1.11.04.2

---------------
nagios-nrpe (2.12-4ubuntu1.11.04.2) natty-proposed; urgency=low

  * [4dc53fb] Use retry argument for start-stop-daemon when stopping nrpe,
    this fixes cases where restarting nagios-nrpe fails to respawn it.
    (LP: #896388)
 -- Stephane Graber <email address hidden> Thu, 03 May 2012 10:16:08 -0400

This bug was fixed in the package nagios-nrpe - 2.12-4ubuntu3.2

---------------
nagios-nrpe (2.12-4ubuntu3.2) oneiric-proposed; urgency=low

  * [4dc53fb] Use retry argument for start-stop-daemon when stopping nrpe,
    this fixes cases where restarting nagios-nrpe fails to respawn it.
    (LP: #896388)
 -- Stephane Graber <email address hidden> Thu, 03 May 2012 10:13:59 -0400