[FFe] [MIR] rabbitmq-stomp, rabbitmq-erlang-client

Bug #948993 reported by Marc Cluet
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rabbitmq-erlang-client (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned
rabbitmq-plugins-common (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned
rabbitmq-server (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned
rabbitmq-stomp (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

Rationale
---------

Prior to rabbitmq-server 2.7.1 the STOMP and erlang-client plugins where not part of rabbitmq-server core and are provided by separate packages.

These plugins are now provided by the rabbitmq-server source package. This obsoletes the rabbitmq-erlang-client, rabbitmq-stomp and rabbitmq-plugins-commons packages in universe.

Restructuring:

a) rabbitmq-plugins-commons will be folded into rabbitmq-server; it just provides .d style configuration for plugin packages.

b) rabbitmq-erlang-client, rabbitmq-stomp will be build from rabbitmq-server; these package enable plugins, add configuration and restart rabbitmq-server only.

The has the result of bring two new binary packages into main (rabbitmq-erlang-client, rabbitmq-stomp).

rabbitmq-erlang-client, rabbitmq-stomp and rabbitmq-plugins-commons source packages can be dropped from the archive once this work is complete.

QA
--

Package upgrade works fine; rabbitmq-plugins-commons is REMOVED and rabbitmq-server works OK with plugins post upgrade.

Build log: see attached
Install and upgrade log: see attached

Dependencies
------------

No new deps.

Tags: patch
James Page (james-page)
Changed in rabbitmq-server (Ubuntu):
milestone: none → ubuntu-12.04-beta-2
status: New → Confirmed
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "rabbitmq-server_2.7.1-0ubuntu2.debdiff" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
James Page (james-page) wrote : Re: rabbitmq-2.7.1-0ubuntu1 lacks compatibility with plugin packages

Added tasks for the obsolete packages as they will need to be removed from the archive one they are built from rabbitmq-server.

Revision history for this message
Marc Cluet (lynxman) wrote :

This is the new debdiff with SpamapS suggestions included

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Marc, the new debdiff looks mostly right. I'm a little concerned about this:

invoke-rc.d rabbitmq-server restart || true

I'd prefer to see

if !invoke-rc.d rabbitmq-server restart ; then
  RESTART_RESULT=$?
  if [ "$RESTART_RESULT"!= "100" ] ; then
    exit $RESTART_RESULT
  fi
fi

Because many of the other responses that invoke-rc.d might give are quite valid errors that the user may want to know about, such as failing to start rabbitmq again.

Revision history for this message
Marc Cluet (lynxman) wrote :

Here's another debdiff with proposed changes by Clint, thanks Clint!

James Page (james-page)
summary: - rabbitmq-2.7.1-0ubuntu1 lacks compatibility with plugin packages
+ [FFe] [MIR] rabbitmq-stomp, rabbitmq-erlang-client
Revision history for this message
James Page (james-page) wrote :
description: updated
description: updated
description: updated
Revision history for this message
James Page (james-page) wrote :
description: updated
Revision history for this message
James Page (james-page) wrote :
Revision history for this message
Dave Walker (davewalker) wrote :

Having followed the testing that has gone into this package... It's been part of the openstack QA lab for quite a while, and validated by at least one other upstream (not cloud).. I'm happy with this.

The main feature, is the universe packages mentioned are now part of upstream. Therefore this source package contains them. The binaries are not yet seeded, so from a distro standpoint, nothing changes.. except building from a federated source package, rather than 3 packages - where two are not official.

This makes perfect sense, thanks for the significant testing.

FFe ACK.

Changed in rabbitmq-server (Ubuntu Precise):
status: Confirmed → In Progress
Revision history for this message
Dave Walker (davewalker) wrote :

James / Marc.. Can you follow up on removals of the legacy source packages please.

Thanks.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rabbitmq-server - 2.7.1-0ubuntu2

---------------
rabbitmq-server (2.7.1-0ubuntu2) precise; urgency=low

  [ Marc Cluet ]
  * Add new rabbitmq-erlang-client and rabbitmq-stomp binary packages as
    plugins are now part of rabbitmq-server core (LP: #948993):
    - d/rules: Refactored to support multiple binary packages, enable
      .d style configuration of rabbitmq for plugins.
    - d/rabbitmq-stomp.[postinst|postrm|install]: Install configuration
      for stomp, enable/disable stomp plugin and restart as required.
    - d/rabbitmq-erlang-client.[postinst|postrm]: Enable/disable amqp_client
      plugin and restart as required.
    - d/rabbitmq-server.*: Renamed to support multiple binary packages.
    - d/rabbitmq-server.dirs: Added rabbitmq.conf.d dir for .d configuration
      files.
    - d/rabbitmq-server.postrm.in: Avoid deletion of rabbitmq user on purge.
  * Switched to source/format 3.0 (quilt):
    - d/patches/inets-plugins.patch: Fixup path to httpd.hrl.

  [ James Page ]
  * d/control: rabbitmq-server needs to Break/Replace
    rabbitmq-plugins-common < 2.7.1.
  * d/rabbitmq-server.links: Fixup link to point to 2.7.1 install.
  * d/rabbitmq-server.init: Restore fix to use start-stop-daemon (LP: #913464).
 -- Marc Cluet <email address hidden> Mon, 12 Mar 2012 08:58:42 +0000

Changed in rabbitmq-server (Ubuntu Precise):
status: In Progress → Fix Released
Revision history for this message
James Page (james-page) wrote :

Please can the source packages:

rabbitmq-stomp
rabbitmq-erlang-client
rabbitmq-plugins-common

Be removed from precise.

They have been superceeded with new binary packages from rabbitmq-server.

Revision history for this message
Colin Watson (cjwatson) wrote :

2012-03-26 10:37:24 INFO Creating lockfile: /var/lock/launchpad-lp-remove-package.lock
2012-03-26 10:37:33 INFO Removing candidates:
2012-03-26 10:37:33 INFO rabbitmq-stomp 2.6.1+hg20110927-0ubuntu1 in precise
2012-03-26 10:37:33 INFO Removed-by: Colin Watson
2012-03-26 10:37:33 INFO Comment: requested by james-page; superseded by rabbitmq-server; LP: #948993
2012-03-26 10:37:34 INFO 1 package successfully removed.
Confirm this transaction? [yes, no] yes
2012-03-26 10:37:40 INFO Transaction committed.
2012-03-26 10:37:40 INFO The archive will be updated in the next publishing cycle.

Changed in rabbitmq-stomp (Ubuntu Precise):
status: New → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote :

2012-03-26 10:37:45 INFO Creating lockfile: /var/lock/launchpad-lp-remove-package.lock
2012-03-26 10:37:55 INFO Removing candidates:
2012-03-26 10:37:55 INFO rabbitmq-erlang-client 2.6.1+hg20110927-0ubuntu1 in precise
2012-03-26 10:37:55 INFO Removed-by: Colin Watson
2012-03-26 10:37:55 INFO Comment: requested by james-page; superseded by rabbitmq-server; LP: #948993
2012-03-26 10:37:55 INFO 1 package successfully removed.
Confirm this transaction? [yes, no] yes
2012-03-26 10:37:57 INFO Transaction committed.
2012-03-26 10:37:57 INFO The archive will be updated in the next publishing cycle.

Changed in rabbitmq-erlang-client (Ubuntu Precise):
status: New → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote :

2012-03-26 10:38:00 INFO Creating lockfile: /var/lock/launchpad-lp-remove-package.lock
2012-03-26 10:38:09 INFO Removing candidates:
2012-03-26 10:38:09 INFO rabbitmq-plugins-common 0.0.1-0ubuntu5 in precise
2012-03-26 10:38:09 INFO rabbitmq-plugins-common 0.0.1-0ubuntu5 in precise amd64
2012-03-26 10:38:09 INFO rabbitmq-plugins-common 0.0.1-0ubuntu5 in precise armel
2012-03-26 10:38:09 INFO rabbitmq-plugins-common 0.0.1-0ubuntu5 in precise armhf
2012-03-26 10:38:09 INFO rabbitmq-plugins-common 0.0.1-0ubuntu5 in precise i386
2012-03-26 10:38:09 INFO rabbitmq-plugins-common 0.0.1-0ubuntu5 in precise powerpc
2012-03-26 10:38:09 INFO Removed-by: Colin Watson
2012-03-26 10:38:09 INFO Comment: requested by james-page; superseded by rabbitmq-server; LP: #948993
2012-03-26 10:38:09 INFO 6 packages successfully removed.
Confirm this transaction? [yes, no] yes
2012-03-26 10:38:11 INFO Transaction committed.
2012-03-26 10:38:11 INFO The archive will be updated in the next publishing cycle.

Changed in rabbitmq-plugins-common (Ubuntu Precise):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.