Ubuntu
ubuntu-dev-tools package

ubuntu-dev-scripts should be ported to Python 3

Bug #1099537 reported by Roland Dreier
34
This bug affects 5 people
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Debian)
Fix Released
Unknown
ubuntu-dev-tools (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

ubuntu-dev-scripts is mostly python2, but should be ported to python3 eventually. There was a brief scare during raring when devscripts went python3-only to remind us that we still have this large body of python2 code that we own. (this bug was originally a crash report from that)

Not all dependencies are ported to python3 yet. As of this writing (2013-01-14), the following are only-python2:
 python-launchpadlib (LP: #1060734)
 python-lazr.restfulclient (LP: #1000801)
 python-mox
 python-soappy

See original description

Related branches

lp:~xnox/ubuntu-dev-tools/py3k
Barry Warsaw: Pending requested
Ubuntu Development Team: Pending requested
Diff: 1965 lines (+467/-335)
25 files modified
debian/changelog (+3/-0)
debian/control (+32/-2)
debian/rules (+9/-8)
setup.py (+13/-7)
ubuntutools/archive.py (+40/-27)
ubuntutools/config.py (+1/-1)
ubuntutools/harvest.py (+10/-7)
ubuntutools/lp/libsupport.py (+9/-6)
ubuntutools/lp/lpapicache.py (+37/-14)
ubuntutools/misc.py (+10/-8)
ubuntutools/question.py (+24/-19)
ubuntutools/requestsync/lp.py (+16/-14)
ubuntutools/requestsync/mail.py (+15/-9)
ubuntutools/sponsor_patch/bugtask.py (+7/-3)
ubuntutools/sponsor_patch/patch.py (+1/-0)
ubuntutools/sponsor_patch/question.py (+3/-1)
ubuntutools/sponsor_patch/source_package.py (+11/-9)
ubuntutools/sponsor_patch/sponsor_patch.py (+14/-9)
ubuntutools/test/test_archive.py (+109/-134)
ubuntutools/test/test_config.py (+34/-13)
ubuntutools/test/test_help.py (+5/-1)
ubuntutools/test/test_logger.py (+6/-3)
ubuntutools/test/test_pylint.py (+0/-3)
ubuntutools/test/test_update_maintainer.py (+47/-28)
ubuntutools/update_maintainer.py (+11/-9)
ubuntu-dev-tools:python3
Mattia Rizzolo: Approve
Diff: 3322 lines (+410/-855)
51 files modified
backportpackage (+2/-2)
bitesize (+3/-3)
check-mir (+3/-5)
debian/changelog (+8/-0)
debian/control (+8/-45)
debian/copyright (+1/-3)
debian/rules (+1/-1)
dev/null (+0/-116)
enforced-editing-wrapper (+1/-1)
grep-merges (+8/-12)
hugdaylist (+16/-15)
import-bug-from-debian (+7/-15)
merge-changelog (+8/-174)
pbuilder-dist (+6/-6)
pull-debian-debdiff (+4/-4)
pull-lp-source (+11/-10)
pull-uca-source (+4/-4)
requestbackport (+13/-8)
requestsync (+39/-37)
reverse-depends (+12/-12)
seeded-in-ubuntu (+17/-17)
setup.py (+40/-48)
sponsor-patch (+2/-2)
submittodebian (+15/-20)
syncpackage (+21/-22)
ubuntu-build (+39/-38)
ubuntu-iso (+6/-6)
ubuntu-upload-permission (+25/-23)
ubuntutools/archive.py (+11/-29)
ubuntutools/builder.py (+5/-4)
ubuntutools/lp/libsupport.py (+1/-6)
ubuntutools/lp/lpapicache.py (+11/-36)
ubuntutools/misc.py (+3/-5)
ubuntutools/question.py (+8/-15)
ubuntutools/requestsync/lp.py (+0/-2)
ubuntutools/requestsync/mail.py (+9/-14)
ubuntutools/sponsor_patch/bugtask.py (+2/-5)
ubuntutools/sponsor_patch/patch.py (+2/-3)
ubuntutools/sponsor_patch/question.py (+0/-2)
ubuntutools/sponsor_patch/source_package.py (+3/-7)
ubuntutools/sponsor_patch/sponsor_patch.py (+1/-6)
ubuntutools/test/__init__.py (+2/-6)
ubuntutools/test/test_archive.py (+6/-18)
ubuntutools/test/test_config.py (+4/-14)
ubuntutools/test/test_flake8.py (+5/-4)
ubuntutools/test/test_help.py (+4/-2)
ubuntutools/test/test_logger.py (+1/-4)
ubuntutools/test/test_pylint.py (+6/-5)
ubuntutools/test/test_update_maintainer.py (+3/-14)
ubuntutools/update_maintainer.py (+0/-2)
update-maintainer (+3/-3)
Revision history for this message
Roland Dreier (roland.dreier) wrote :
information type: Private → Public
Apport retracing service (apport)
tags: removed: need-duplicate-check
Changed in ubuntu-dev-tools (Ubuntu):
importance: Undecided → Medium
Michael Terry (mterry)
summary: - requestsync crashed with ImportError in /usr/lib/python2.7/dist-
- packages/ubuntutools/config.py: No module named devscripts.logger
+ ubuntu-dev-scripts needs to be ported to Python 3
description: updated
Revision history for this message
Stefano Rivera (stefanor) wrote : Re: ubuntu-dev-scripts needs to be ported to Python 3

It can't fallow suit, lanuchpadlib doesn't support python3

Michael Terry (mterry)
summary: - ubuntu-dev-scripts needs to be ported to Python 3
+ ubuntu-dev-scripts should be ported to Python 3
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-dev-tools (Ubuntu):
status: New → Confirmed
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

FYI, the corrisponding request for python-launchpadlib

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

err... That should have read:

FYI, the corresponding request for python-launchpadlib is in LP: #1060734

Benjamin Drung (bdrung)
description: updated
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

lazr.restfulclient will probably be the biggest problem, see https://bugs.launchpad.net/lazr.restfulclient/+bug/1000801/comments/2

description: updated
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

python3-launchpadlib is now available in vivid

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I've ported launchpadlib, lazr.restfulclient.
I've removed mox dependency.
Soappy is only used in one script, and that one can stay on python2.
In fact my current port does not change _any_ scripts to python3, only test suite and the core modules are ported.
Individual scripts will need further porting & smoke-testing.

Changed in ubuntu-dev-tools (Ubuntu):
assignee: nobody → Dimitri John Ledkov (xnox)
status: Confirmed → In Progress
Dimitri John Ledkov (xnox)
Changed in ubuntu-dev-tools (Ubuntu):
assignee: Dimitri John Ledkov (xnox) → nobody
Revision history for this message
Dan Streetman (ddstreet) wrote :

fixed in
https://git.launchpad.net/~ddstreet/ubuntu-dev-tools/+git/ubuntu-dev-tools/commit/?id=4eb794e9f6760b5390e01df7b28088f22151f342

Revision history for this message
Nico Schlömer (nschloe) wrote :

@ddstreet Very nice!

Mattia Rizzolo (mapreri)
Changed in ubuntu-dev-tools (Ubuntu):
status: In Progress → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in ubuntu-dev-tools (Debian):
status: Unknown → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in ubuntu-dev-tools (Debian):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.173

---------------
ubuntu-dev-tools (0.173) unstable; urgency=medium

  [ Stefano Rivera ]
  * pull-debian-debdiff:
    + Don't unpack the older source package, it will often use the same
      directory as the newer one, and break.
  * merge-changelog:
    + Use ubuntutools.version.Version, to support Python 3.
  * Drop 404main, it's been totally broken for years.
  * Port all the Python scripts to Python 3, and remove Python 2 support.
    Closes: #938740, LP: #1099537

  [ Dan Streetman ]
  * pull-pkg:
    + Use ubuntutools.version.Version which has strip_epoch() instead
      of debian.debian_support.Version.
  * Have ubuntu-dev-tools depend on the matching version of python3-ubuntutools.

  [ Scott Kitterman ]
  * Update requestsync to python3. Closes: #927147

  [ Mattia Rizzolo ]
  * Explicitly require Python3 >= 3.6.

 -- Mattia Rizzolo <email address hidden> Tue, 10 Sep 2019 15:35:06 +0200

Changed in ubuntu-dev-tools (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Mattia Rizzolo (mapreri) wrote : Re: [Bug 1099537] Re: ubuntu-dev-scripts should be ported to Python 3

@jbicha: this very much required a FFe, which was rejected in
https://bugs.launchpad.net/bugs/1843543 .......

On Fri, 20 Sep 2019, 2:21 am Launchpad Bug Tracker, <
<email address hidden>> wrote:

> This bug was fixed in the package ubuntu-dev-tools - 0.173
>
> ---------------
> ubuntu-dev-tools (0.173) unstable; urgency=medium
>
> [ Stefano Rivera ]
> * pull-debian-debdiff:
> + Don't unpack the older source package, it will often use the same
> directory as the newer one, and break.
> * merge-changelog:
> + Use ubuntutools.version.Version, to support Python 3.
> * Drop 404main, it's been totally broken for years.
> * Port all the Python scripts to Python 3, and remove Python 2 support.
> Closes: #938740, LP: #1099537
>
> [ Dan Streetman ]
> * pull-pkg:
> + Use ubuntutools.version.Version which has strip_epoch() instead
> of debian.debian_support.Version.
> * Have ubuntu-dev-tools depend on the matching version of
> python3-ubuntutools.
>
> [ Scott Kitterman ]
> * Update requestsync to python3. Closes: #927147
>
> [ Mattia Rizzolo ]
> * Explicitly require Python3 >= 3.6.
>
> -- Mattia Rizzolo <email address hidden> Tue, 10 Sep 2019 15:35:06 +0200
>
> ** Changed in: ubuntu-dev-tools (Ubuntu)
> Status: Fix Committed => Fix Released
>
> --
> You received this bug notification because you are subscribed to Ubuntu.
> https://bugs.launchpad.net/bugs/1099537
>
> Title:
> ubuntu-dev-scripts should be ported to Python 3
>
> Status in ubuntu-dev-tools package in Ubuntu:
> Fix Released
> Status in ubuntu-dev-tools package in Debian:
> Fix Released
>
> Bug description:
> ubuntu-dev-scripts is mostly python2, but should be ported to python3
> eventually. There was a brief scare during raring when devscripts
> went python3-only to remind us that we still have this large body of
> python2 code that we own. (this bug was originally a crash report
> from that)
>
> Not all dependencies are ported to python3 yet. As of this writing
> (2013-01-14), the following are only-python2:
> python-launchpadlib (LP: #1060734)
> python-lazr.restfulclient (LP: #1000801)
> python-mox
> python-soappy
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/ubuntu-dev-tools/+bug/1099537/+subscriptions
>
>

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Mattia, I apologize. I misunderstood how important it was to switch from python2 to python3 at this point. I'll avoid pushing any more python2-to-python3 stuff for eoan (at least without asking around first).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.