Connecting/disconnecting notification changes

Cody, thanks for the patch. Can you please forward this to an upstream bug and link it here?

Alex, can you please review this?

This should be done in accordance with upstream, since it changes strings, and thus keeping it as an Ubuntu patch would introduce a permanent desync between upstream and our translations.

Wouldn't it make the code more readable (less fragmented) if we stopped doing the "early" return when != ACTIVATED and put the different code for ACTIVATED and DEACTIVATED to the bottom?

btw, i will take care about the upstreaming once we have the patch in our branch.

revno: 20

committed the "connecting" part to bzr (see Related Branches section of this bug); please open a new bug for the "disconnecting" part so we can deal with that later. Thanks.

This bug was fixed in the package network-manager-applet - 0.7.1~rc3-0ubuntu1

---------------
network-manager-applet (0.7.1~rc3-0ubuntu1) jaunty; urgency=low

  * new upstream RC 0.7.1rc3
    + rev: 982
    + revision-id: svn-v3-trunk0:9c6bbc85-7128-0410-879a-9bbc9e4270e9:branches%2FNETWORKMANAGER_APPLET_0_7:1212
    + branch: http://bzr-playground.gnome.org/network-manager-applet/branches/NETWORKMANAGER_APPLET_0_7/
    - update .bzr-builddeb/default.conf
  * bump lower builds for network-manager build depends to >= 0.7.1~rc3
    - update control
  * fix LP: #328572 - Connecting/disconnecting notification changes; we apply the
    the "Connecting" part of this patch, as the disconnecting part would require
    string changes that need to be done upstream
    - add patches/lp328572-dxteam-connect-text.patch
    - update patches/series
  * fix LP: #330571 - Wired connected message in nm-applet too long
    - add patches/lp330571_dxteam_wired_connect_text.patch
    - update patches/series
  * fix LP: #330608 - GSM connection message too long in nm-applet
    - add patches/lp330608_dxteam_gsm_connect_text.patch
    - update patches/series
  * fix LP: #337960 - nm-applet jaunty icon changes - brought to you by d(u)xteam;
    we apply two patches: first patch changes the icon names referred to in notifications;
    second patch ships fallback icons for those names within network-manager-gnome
    package

 -- Alexander Sack <email address hidden> Thu, 05 Mar 2009 01:30:46 +0100

Alexander, are these changes incorporated upstream yet? If not, could you link this report to the upstream report? Thanks.

Ubuntu still carries this patch as of Raring.

Ubuntu still carries this patch (and two more just like it) as of Utopic.

Was upstream ever contacted?